r95723 MediaWiki - Code Review archive

In donationinterface.php:

foreach ( $wgDonationInterfaceEnabledGateways as $gateway ) {
	//include 'em
	require_once( $donationinterface_dir . $gateway . '_gateway/' . $gateway . '_gateway.php' );
}

This should take advantage of the class autoloading in Mediawiki ($wgAutloadClasses['<class name'>] = '/path/to/class';

As a side note, I feel like the autoloading of the form classes in there can be done much more elegantly than it is now, but this is pretty minor.

In gateway.adapter.php:

/**
  * Actually do... stuff. Here. 
  * TODO: Better comment. 
  * Process the entire response gott'd by the last four functions. 
  */

This is unprecedented meta-irony.

	//ALL OF THESE need to be redefined in the children. Much voodoo depends on the accuracy of these constants. 
	const gatewayname = 'Donation Gateway';
	const identifier = 'donation';
	const communicationtype = 'xml'; //this needs to be either 'xml' or 'namevalue'
	const globalprefix = 'wgDonationGateway'; //...for example. 

Constants should be all uppercase, with underscores.

Also:

$this->url = self::getGlobal('TestingURL');

Should be:

$this->url = self::getGlobal( 'TestingURL' );

I could go on, but in general, take a look at: http://www.mediawiki.org/wiki/Coding_conventions

More to come :)

I have definitely fixed all the things here, and more, in later revisions on this branch. (Latest DonationInterface rev at the time of this comment is r97833.)

This code is in development. Please see latest revision.