r95691 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95690‎ | r95691 | r95692 >
Date:19:53, 29 August 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
make campaign table sortable
Modified paths:
  • /trunk/extensions/UploadWizard/includes/specials/SpecialUploadCampaigns.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/specials/SpecialUploadCampaigns.php
@@ -157,18 +157,20 @@
158158
159159 $out->addHTML( Xml::openElement(
160160 'table',
161 - array( 'class' => 'wikitable', 'style' => 'width:400px' )
 161+ array( 'class' => 'wikitable sortable', 'style' => 'width:400px' )
162162 ) );
163163
164164 $out->addHTML(
165 - '<tr>' .
 165+ '<thead><tr>' .
166166 Html::element( 'th', array(), wfMsg( 'mwe-upwiz-campaigns-name' ) ) .
167167 Html::element( 'th', array(), wfMsg( 'mwe-upwiz-campaigns-status' ) ) .
168168 Html::element( 'th', array(), wfMsg( 'mwe-upwiz-campaigns-edit' ) ) .
169169 Html::element( 'th', array(), wfMsg( 'mwe-upwiz-campaigns-delete' ) ) .
170 - '</tr>'
 170+ '</tr></thead>'
171171 );
172172
 173+ $out->addHTML( '<tbody>' );
 174+
173175 foreach ( $campaigns as $campaign ) {
174176 $out->addHTML(
175177 '<tr>' .
@@ -205,6 +207,7 @@
206208 );
207209 }
208210
 211+ $out->addHTML( '</tbody>' );
209212 $out->addHTML( '</table>' );
210213 }
211214

Follow-up revisions

RevisionCommit summaryAuthorDate
r958871.17wmf1: MFT UploadWizard fixes r95691, r95726, r95727, r95793, r95815, r958...catrope17:10, 31 August 2011

Status & tagging log