r95605 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95604‎ | r95605 | r95606 >
Date:18:35, 27 August 2011
Author:robin
Status:ok
Tags:
Comment:
* InfoPage CSS fixes
* fix parameter for displayPrefix()
* correct $wgAddGroups and $wgRemoveGroups syntax
Modified paths:
  • /trunk/extensions/WikimediaIncubator/InfoPage.css (modified) (history)
  • /trunk/extensions/WikimediaIncubator/SpecialViewUserLang.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaIncubator/InfoPage.css
@@ -50,6 +50,6 @@
5151 #ca-nstab-main a {
5252 color: black;
5353 }
54 -#siteNotice {
55 - border-bottom: 1px solid silver;
 54+.subpages {
 55+ display: none;
5656 }
\ No newline at end of file
Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.php
@@ -14,7 +14,7 @@
1515 'path' => __FILE__,
1616 'name' => 'Wikimedia Incubator',
1717 'author' => 'SPQRobin',
18 - 'version' => '4.3.1',
 18+ 'version' => '4.3.2',
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:WikimediaIncubator',
2020 'descriptionmsg' => 'wminc-desc',
2121 );
@@ -64,8 +64,8 @@
6565 $wgGroupPermissions['test-sysop']['block'] = true;
6666 $wgGroupPermissions['test-sysop']['blockemail'] = true;
6767 $wgGroupPermissions['test-sysop']['rollback'] = true;
68 -$wgAddGroups['bureaucrat']['test-sysop'] = true;
69 -$wgRemoveGroups['bureaucrat']['test-sysop'] = true;
 68+$wgAddGroups['bureaucrat'][] = 'test-sysop';
 69+$wgRemoveGroups['bureaucrat'][] = 'test-sysop';
7070
7171 $wgExtensionMessagesFiles['WikimediaIncubator'] = $dir . 'WikimediaIncubator.i18n.php';
7272 $wgExtensionAliasesFiles['WikimediaIncubator'] = $dir . 'WikimediaIncubator.alias.php';
Index: trunk/extensions/WikimediaIncubator/SpecialViewUserLang.php
@@ -84,7 +84,7 @@
8585 $userproject = $user->getOption( $wmincPref . '-project' );
8686 $userproject = ( $userproject ? $userproject : 'none' );
8787 $usercode = $user->getOption( $wmincPref . '-code' );
88 - $prefix = IncubatorTest::displayPrefix( $userproject, $usercode );
 88+ $prefix = IncubatorTest::displayPrefix( $userproject, $usercode ? $usercode : 'none' );
8989 if ( IncubatorTest::isContentProject( $userproject ) ) {
9090 $testwiki = $linker->link( Title::newFromText( $prefix ) );
9191 } elseif ( $prefix == $wmincProjectSite['short'] ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r958911.17wmf1: MFT r95586, r95605catrope17:46, 31 August 2011

Status & tagging log