r95596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95595‎ | r95596 | r95597 >
Date:10:11, 27 August 2011
Author:wikinaut
Status:reverted (Comments)
Tags:
Comment:
Patch to make SpecialPasswordReset only available to groups
with a new minimum right 'resetpassword'. Default group: '*'. Description: wikitech-l http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55055 'Reclaiming a lost account on a private wiki: impossible'
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPasswordReset.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -3380,6 +3380,7 @@
33813381 /** @cond file_level_code */
33823382 // Implicit group for all visitors
33833383 $wgGroupPermissions['*']['createaccount'] = true;
 3384+$wgGroupPermissions['*']['resetpassword'] = true;
33843385 $wgGroupPermissions['*']['read'] = true;
33853386 $wgGroupPermissions['*']['edit'] = true;
33863387 $wgGroupPermissions['*']['createpage'] = true;
Index: trunk/phase3/includes/specials/SpecialPasswordReset.php
——@@ -29,7 +29,7 @@
3030 class SpecialPasswordReset extends FormSpecialPage {
3131
3232 public function __construct() {
33 - parent::__construct( 'PasswordReset' );
 33+ parent::__construct( 'PasswordReset', 'resetpassword' );
3434 }
3535
3636 public function userCanExecute( User $user ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r95618this commit reverts my r95596 because that patch for a new right 'resetpasswo...wikinaut06:53, 28 August 2011

Comments

#Comment by Dantman (talk | contribs)   10:31, 27 August 2011

Can you enlighten me what the problem being solved here is? As I understand it the bug is that on wiki with ['*']['view']=false users can't get a password reset e-mail. How does adding a new permission that potentially restricts PasswordReset even more fix the issue that a logged out user can't view the passwordreset special page? Isn't the correct fix here to add PasswordReset to the default whitelist?

#Comment by Wikinaut (talk | contribs)   10:43, 27 August 2011

the other way around. It's for wikis where all pages can be viewed, but only - for example Sysops - can trigger reset password.

#Comment by Reach Out to the Truth (talk | contribs)   21:40, 27 August 2011

I'm not clear on how this would fix that. No restrictions were removed or loosened here, instead you've made it easier to add restrictions. Is there another part of this fix that hasn't been committed yet?

#Comment by P858snake (talk | contribs)   10:40, 27 August 2011

.

#Comment by Duplicatebug (talk | contribs)   19:40, 27 August 2011

Please create MediaWiki:Right-resetpassword (and add it to the maintenance file) for localisation on Special:ListGroupRights. Thanks.

#Comment by Wikinaut (talk | contribs)   06:54, 28 August 2011

reverted in r95618 (because r95596 raised more questions than it solved problems)

Status & tagging log