r95540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95539‎ | r95540 | r95541 >
Date:22:28, 25 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r95525, fix failing parser tests

Failure:
ConvertTests::testParserTest with data set #11 ('#language', '*{{#convert: 10 m | km | #language=en-gb }}
*{{#convert: 10m | km | #language = en-gb }}
*{{#convert: 10 km | m |#language=en-gb}}
*{{#convert: 10 Pa | mmHg | #language = en-gb }}', '<ul><li>0.01 kilometres
</li><li>0.01kilometres
</li><li>10,000 metres
</li><li>0.1 milimetres of mercury
</li></ul>
', '', '')
#language
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
<ul><li>0.01 kilometres
</li><li>0.01kilometres
</li><li>10,000 metres
-</li><li>0.1 milimetres of mercury
+</li><li>0.1 millimetres of mercury
</li></ul>

/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/includes/parser/NewParserTest.php:539
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiTestCase.php:60
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiPHPUnitCommand.php:31
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/phpunit.php:60

ConvertTests::testParserTest with data set #12 ('Case sensitivity', '*{{#convert: 10 mm | m }}
*{{#convert: 10 Mm | m }}
*{{#convert: 10 km | Mm }}
*{{#convert: 10 Pa | mmHg }}
*{{#convert: 10 pa | mmHg }}', '<ul><li>0.01 meters
</li><li>10,000,000 meters
</li><li>0.01 megameters
</li><li>0.1 milimeters of mercury
</li><li><strong class="error">Error: Unknown unit "pa".</strong>
</li></ul>
', '', '')
Case sensitivity
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
<ul><li>0.01 meters
</li><li>10,000,000 meters
</li><li>0.01 megameters
-</li><li>0.1 milimeters of mercury
+</li><li>0.1 millimeters of mercury
</li><li><strong class="error">Error: Unknown unit "pa".</strong>
</li></ul>

/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/includes/parser/NewParserTest.php:539
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiTestCase.php:60
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiPHPUnitCommand.php:31
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/phpunit.php:60
Modified paths:
  • /trunk/extensions/ParserFunctions/convertTests.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/convertTests.txt
@@ -203,7 +203,7 @@
204204 <ul><li>0.01 kilometres
205205 </li><li>0.01kilometres
206206 </li><li>10,000 metres
207 -</li><li>0.1 milimetres of mercury
 207+</li><li>0.1 millimetres of mercury
208208 </li></ul>
209209
210210 !! end
@@ -220,7 +220,7 @@
221221 <ul><li>0.01 meters
222222 </li><li>10,000,000 meters
223223 </li><li>0.01 megameters
224 -</li><li>0.1 milimeters of mercury
 224+</li><li>0.1 millimeters of mercury
225225 </li><li><strong class="error">Error: Unknown unit "pa".</strong>
226226 </li></ul>
227227

Follow-up revisions

RevisionCommit summaryAuthorDate
r95544MFT r78137 - r95540awjrichards23:20, 25 August 2011
r964981.18: MFT r95171, r95409, r95436, r95458, r95467, r95470, r95475, r95493, r95...catrope21:04, 7 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95525Follow-up r81074: fix typos in some unit names and messages ("mili" instead o...happy-melon21:22, 25 August 2011

Status & tagging log