r95530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95529‎ | r95530 | r95531 >
Date:21:41, 25 August 2011
Author:yaron
Status:resolved (Comments)
Tags:
Comment:
More code improvements
Modified paths:
  • /trunk/extensions/MeanEditor/MeanEditor.i18n.php (modified) (history)
  • /trunk/extensions/MeanEditor/MeanEditor.php (modified) (history)
  • /trunk/extensions/MeanEditor/MeanEditorEditPage.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MeanEditor/MeanEditor.i18n.php
@@ -1,6 +1,7 @@
22 <?php
33 $messages = array();
44 $messages['en'] = array(
 5+ 'descriptionmsg' => 'The mean, the safe and the ugly visual editor for non-technical users. Based on WYMeditor and jQuery.',
56 'prefer_traditonal_editor' => 'Do not use the visual editor',
67 'meaneditor_desc' => 'The mean, the safe and the ugly visual editor for non-technical users. Based on WYMeditor and jQuery.',
78 'no_recent_images' => 'No recently uploaded images.',
Index: trunk/extensions/MeanEditor/MeanEditorEditPage.body.php
@@ -171,9 +171,6 @@
172172 wfProfileOut( __METHOD__ );
173173 }
174174
175 -
176 -
177 -
178175 /**
179176 * We need to read the checkbox and the hidden value to know if the
180177 * visual editor was used or not
@@ -250,7 +247,6 @@
251248 $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
252249 }
253250
254 -
255251 # We need to add the class 'wymupdate' to all buttons
256252 public function getEditButtons(&$tabindex) {
257253 $buttons = array();
@@ -297,5 +293,4 @@
298294 return $buttons;
299295 }
300296
301 -
302297 }
Index: trunk/extensions/MeanEditor/MeanEditor.php
@@ -15,12 +15,18 @@
1616 $wgExtensionCredits['other'][] = array(
1717 'name' => 'MeanEditor',
1818 'author' => 'Jacopo Corbetta and Alessandro Pignotti for Antonio Gulli',
19 - 'description' => 'The mean, the safe and the ugly visual editor for non-technical users. Based on WYMeditor and jQuery.',
2019 'descriptionmsg' => 'meaneditor_desc',
2120 'url' => 'http://www.mediawiki.org/wiki/Extension:MeanEditor',
2221 'version' => '0.5.5'
2322 );
2423
 24+$wgHooks['EditPage::wiki2html'][] = 'meaneditor_wiki2html';
 25+$wgHooks['EditPage::html2wiki'][] = 'meaneditor_html2wiki';
 26+$wgHooks['EditPage::showBox'][] = 'meaneditor_showBox';
 27+$wgHooks['CustomEditor'][] = 'meaneditor_customeditor';
 28+$wgHooks['EditPageBeforeEditChecks'][] = 'meaneditor_checkboxes';
 29+$wgHooks['EditPageBeforeEditToolbar'][] = 'meaneditor_disabletoolbar';
 30+
2531 function substitute_hashed_img_urls($text)
2632 {
2733 while (preg_match('/\[\[Image:(.*?)\]\]/', $text, $matches)) {
@@ -515,10 +521,3 @@
516522 $toolbar = '';
517523 return false;
518524 }
519 -
520 -$wgHooks['EditPage::wiki2html'][] = 'meaneditor_wiki2html';
521 -$wgHooks['EditPage::html2wiki'][] = 'meaneditor_html2wiki';
522 -$wgHooks['EditPage::showBox'][] = 'meaneditor_showBox';
523 -$wgHooks['CustomEditor'][] = 'meaneditor_customeditor';
524 -$wgHooks['EditPageBeforeEditChecks'][] = 'meaneditor_checkboxes';
525 -$wgHooks['EditPageBeforeEditToolbar'][] = 'meaneditor_disabletoolbar';

Follow-up revisions

RevisionCommit summaryAuthorDate
r95554Revert of r95530 for MeanEditor.i18n.php - removed unnecessary additionyaron12:22, 26 August 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:28, 26 August 2011

MeanEditor.i18n.php change looks wrong.

#Comment by Yaron Koren (talk | contribs)   12:23, 26 August 2011

Indeed - I just undid that change. Thanks.

Status & tagging log