r95524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95523‎ | r95524 | r95525 >
Date:21:22, 25 August 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Fux PHP Notice: Undefined property: ContribsPager::$showSizeDiff in /www/w/includes/specials/SpecialContributions.php on line 681 frin r95496
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -677,10 +677,9 @@
678678
679679 $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
680680
 681+ $diffOut = ' . . ' . $wgLang->getDirMark() .
 682+ ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len );
681683
682 - $diffOut = ' . . ' . $wgLang->getDirMark() . ( $this->showSizeDiff ?
683 - ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len ) : '' );
684 -
685684 $ret = "{$del}{$d} {$diffHistLinks} {$nflag}{$mflag} {$link}{$diffOut}{$userlink} {$comment} {$topmarktext}";
686685
687686 # Denote if username is redacted for this edit

Follow-up revisions

RevisionCommit summaryAuthorDate
r96090Revert r95496, r95506, r95524, r95553, r96005reedy11:04, 2 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95496Revert r8811...reedy17:35, 25 August 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:26, 26 August 2011

Googling for fux didn't turn out to be a so good idea after all.

Status & tagging log