r95501 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95500‎ | r95501 | r95502 >
Date:19:05, 25 August 2011
Author:hashar
Status:ok
Tags:
Comment:
converts private var from r95043 to protected

Seems like the consensus is to use 'protected' for new class properties.
Modified paths:
  • /trunk/extensions/CodeReview/backend/DiffHighlighter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/DiffHighlighter.php
@@ -5,18 +5,18 @@
66 */
77 class CodeDiffHighlighter {
88 /* chunk line count for the original file */
9 - private $left = 0;
 9+ protected $left = 0;
1010 /* chunk line count for the changed file */
11 - private $right = 0;
 11+ protected $right = 0;
1212 /* number of chunks */
13 - private $chunk = 0;
 13+ protected $chunk = 0;
1414 /* line number inside patch */
15 - private $lineNumber = 0;
 15+ protected $lineNumber = 0;
1616
1717 /* CodeRepository: The repository for this revision */
18 - private $repo = null;
 18+ protected $repo = null;
1919 /* CodeRevision: revision the diff comes from */
20 - private $rev = null;
 20+ protected $rev = null;
2121
2222 /**
2323 * Comments inside the diff.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95043line numbers and better style...hashar21:00, 19 August 2011

Status & tagging log