r95500 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95499‎ | r95500 | r95501 >
Date:18:35, 25 August 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fixes to CSS to get combo boxes looking correct when forms are used with Header Tabs extension
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SemanticForms.js (modified) (history)
  • /trunk/extensions/SemanticForms/skins/SemanticForms.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/skins/SemanticForms.css
@@ -134,3 +134,7 @@
135135 vertical-align: bottom;
136136 margin-top: 0.2em;
137137 } /* button elements seem to need a little more width */
 138+/* Override CSS from Header Tabs extension, if tabs are used in the form */
 139+input.sfComboBoxActual {
 140+ border: 1px #a6a6a6 solid;
 141+}
Index: trunk/extensions/SemanticForms/libs/SemanticForms.js
@@ -886,6 +886,14 @@
887887 text: false
888888 }).removeClass("ui-corner-all")
889889 .addClass("ui-corner-right ui-button-icon sfComboBoxActual")
 890+ // Add some inline CSS, to override CSS set by the
 891+ // jquery.ui.tabs module - this is necessary if form is
 892+ // used in conjunction with the Header Tabs extension.
 893+ // 'cssText' attribute is needed because the normal
 894+ // .css() calls don't allow for setting "!important",
 895+ // which is needed to counteract "!important" coming
 896+ // from the jquery.ui.tabs CSS.
 897+ .css('cssText', 'padding: 0 !important; margin: 0 !important; -moz-border-radius: 0; -webkit-border-radius: 0; width: 1.7em;')
890898 .click(function() {
891899 // close if already visible
892900 if (input.autocomplete("widget").is(":visible")) {