r95474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95473‎ | r95474 | r95475 >
Date:10:47, 25 August 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Actually do r95462 as intended

r95396
Modified paths:
  • /trunk/phase3/includes/SpecialPageFactory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPageFactory.php
@@ -126,8 +126,8 @@
127127 // Page tools
128128 'ComparePages' => 'SpecialComparePages',
129129 'Export' => 'SpecialExport',
130 - 'GlobalFileUsage' => 'SpecialGlobalFileUsage',
131 - 'GlobalTemplateUsage' => 'SpecialGlobalTemplateUsage',
 130+ 'Globalfileusage' => 'SpecialGlobalFileUsage',
 131+ 'Globaltemplateusage' => 'SpecialGlobalTemplateUsage',
132132 'Import' => 'SpecialImport',
133133 'Undelete' => 'SpecialUndelete',
134134 'Whatlinkshere' => 'SpecialWhatlinkshere',
@@ -264,7 +264,7 @@
265265 /**
266266 * Add a page to a certain display group for Special:SpecialPages
267267 *
268 - * @param $page Mixed: SpecialPage or string
 268+ * @param $page SpecialPage|string
269269 * @param $group String
270270 */
271271 public static function setGroup( $page, $group ) {
@@ -277,6 +277,8 @@
278278 * Get the group that the special page belongs in on Special:SpecialPage
279279 *
280280 * @param $page SpecialPage
 281+ *
 282+ * @return string
281283 */
282284 public static function getGroup( &$page ) {
283285 $name = $page->getName();

Follow-up revisions

RevisionCommit summaryAuthorDate
r96325Cleanup to r95402, r95474: "Not using CamelCase is so 2001."demon12:39, 6 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95396Merge the iwtransclusion branch back into trunk...reedy13:03, 24 August 2011
r95462Hopefully fix...reedy08:31, 25 August 2011

Comments

#Comment by 😂 (talk | contribs)   12:27, 6 September 2011

Like it was already mentioned, can't we just make the names CamelCase?

Status & tagging log