r95461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95460‎ | r95461 | r95462 >
Date:08:28, 25 August 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Fix calls to undefined Xml::hidden


r95396
Modified paths:
  • /trunk/phase3/includes/specials/SpecialGlobalFileUsage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialGlobalTemplateUsage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialGlobalFileUsage.php
@@ -43,9 +43,9 @@
4444 /* Build form */
4545 $html = Xml::openElement( 'form', array( 'action' => $wgScript ) ) . "\n";
4646 // Name of SpecialPage
47 - $html .= Xml::hidden( 'title', $this->getTitle()->getPrefixedText() ) . "\n";
 47+ $html .= Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) . "\n";
4848 // Limit
49 - $html .= Xml::hidden( 'limit', $wgRequest->getInt( 'limit', 50 ) );
 49+ $html .= Html::hidden( 'limit', $wgRequest->getInt( 'limit', 50 ) );
5050 // Input box with target prefilled if available
5151 $formContent = "\t" . Xml::input( 'target', 40, is_null( $this->target ) ? ''
5252 : $this->target->getText() )
Index: trunk/phase3/includes/specials/SpecialGlobalTemplateUsage.php
@@ -46,9 +46,9 @@
4747 /* Build form */
4848 $html = Xml::openElement( 'form', array( 'action' => $wgScript ) ) . "\n";
4949 // Name of SpecialPage
50 - $html .= Xml::hidden( 'title', $this->getTitle( )->getPrefixedText( ) ) . "\n";
 50+ $html .= Html::hidden( 'title', $this->getTitle( )->getPrefixedText( ) ) . "\n";
5151 // Limit
52 - $html .= Xml::hidden( 'limit', $wgRequest->getInt( 'limit', 50 ) );
 52+ $html .= Html::hidden( 'limit', $wgRequest->getInt( 'limit', 50 ) );
5353 // Input box with target prefilled if available
5454 $formContent = "\t" . Xml::input( 'target', 40, is_null( $this->target ) ? ''
5555 : $this->target->getPrefixedText( ) )
@@ -92,7 +92,6 @@
9393 return;
9494 }
9595
96 - $offset = $query->getOffsetString( );
9796 $navbar = $this->getNavBar( $query );
9897 $targetName = $this->target->getPrefixedText( );
9998

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95396Merge the iwtransclusion branch back into trunk...reedy13:03, 24 August 2011

Comments

#Comment by Raymond (talk | contribs)   08:31, 25 August 2011

Is the removal of this line intended? Not mentioned in the commit message

-		$offset = $query->getOffsetString( );
#Comment by Reedy (talk | contribs)   10:42, 25 August 2011

Yeah, just removed it as the variable was unused

Status & tagging log