r95410 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95409‎ | r95410 | r95411 >
Date:18:35, 24 August 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Followup r85876

Fix the fixme
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -116,6 +116,7 @@
117117 if( $this->mTarget != '' ) {
118118 $ret = ( $ret == 'notarget' ) ? 'emailnotarget' : ( $ret . 'text' );
119119 $out->addHTML( '<p class="error">' . wfMessage( $ret )->parse() . '</p>' );
 120+ $out->wrapWikiMsg( "<p class='error'>$1</p>", $ret );
120121 }
121122 $out->addHTML( $this->userForm( $this->mTarget ) );
122123 return false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r95442Remove line that should have been removed in r95410reedy20:32, 24 August 2011
r96088MFT to REL1_18...hashar10:53, 2 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85876(bug 13879) Special:Emailuser now asks for suitable target user if called wit...purodha12:49, 12 April 2011

Comments

#Comment by 😂 (talk | contribs)   20:29, 24 August 2011

addHTML() and wrapWikiMsg()? I think the suggestion was to swap the latter for the former.

Status & tagging log