r95407 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95406‎ | r95407 | r95408 >
Date:18:09, 24 August 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Revert most of r93261

Leave change from named color 'gainsboro' to hex #DCDCDC
Modified paths:
  • /trunk/phase3/skins/modern/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/modern/main.css
——@@ -1,6 +1,6 @@
22 body {
3 - margin: 0;
4 - padding: 0;
 3+ margin: 0 0 0 0;
 4+ padding: 0 0 0 0;
55 /*font-size: 10pt;*/
66 font-size: x-small;
77
——@@ -24,19 +24,19 @@
2525 position: absolute;
2626 top: 0;
2727 left: 0;
28 - margin: 0;
29 - padding: 0;
 28+ margin: 0 0 0 0;
 29+ padding: 0 0em 0 0em;
3030 border: none;
3131 height: 2em;
3232 width: 100%;
3333
34 - background-color: #036;
 34+ background-color: #003366;
3535 color: white;
3636 }
3737
3838 #mw_header h1 {
39 - margin: 0 0 0 .5em;
40 - padding: 0;
 39+ margin: 0 0 0 0.5em;
 40+ padding: 0 0 0 0;
4141 text-decoration: none;
4242 font-size: 150%;
4343 }
——@@ -46,15 +46,15 @@
4747 top: 2em;
4848 left: 0;
4949 height: 1.5em;
50 - margin: 0;
51 - padding: 0;
 50+ margin: 0 0 0 0;
 51+ padding: 0 0 0 0;
5252 width: 100%;
5353
5454 }
5555
5656 #p-personal div.pBody {
57 - margin: 0;
58 - padding: 0;
 57+ margin: 0 0 0 0;
 58+ padding: 0 0 0 0;
5959 height: 1.5em;
6060 font-variant: small-caps;
6161 }
——@@ -64,8 +64,8 @@
6565 }
6666
6767 #p-personal ul {
68 - margin: 0;
69 - padding: 0;
 68+ margin: 0 0 0 0;
 69+ padding: 0 0 0 0;
7070 display: block;
7171 height: 1.5em;
7272 background-color: #3c78b5;
——@@ -75,7 +75,7 @@
7676 display: block;
7777 float: left;
7878 height: 1.5em;
79 - margin: 0;
 79+ margin: 0 0 0 0;
8080 vertical-align: middle;
8181
8282 font-weight: bold;
——@@ -85,7 +85,7 @@
8686 #p-personal li a {
8787 text-decoration: none;
8888 color: white;
89 - padding: 0 1em;
 89+ padding: 0 1em 0 1em;
9090 }
9191
9292 #p-personal li a:hover {
——@@ -94,7 +94,7 @@
9595 }
9696
9797 #p-personal li:hover {
98 - background-color: #036;
 98+ background-color: #003366;
9999 }
100100
101101 #jump-to-nav {
——@@ -111,40 +111,40 @@
112112 margin: 0 0 0 14em;
113113
114114 background-color: white;
115 - border-top: solid 1px #bbb;
116 - border-left: solid 1px #bbb;
117 - border-bottom: solid 1px #bbb;
 115+ border-top: solid 1px #bbbbbb;
 116+ border-left: solid 1px #bbbbbb;
 117+ border-bottom: solid 1px #bbbbbb;
118118
119119 line-height: 1.5em;
120 - padding: 0 1em 1em;
 120+ padding: 0 1em 1em 1em;
121121 }
122122
123123 #mw_portlets {
124124 width: 14em;
125125
126 - border-right: solid 1px #bbb;
 126+ border-right: solid 1px #bbbbbb;
127127 background-color: #f0f0f0;
128128 }
129129
130130 #mw_main {
131 - padding: 0;
132 - margin: 0;
 131+ padding: 0 0 0 0;
 132+ margin: 0 0 0 0;
133133 margin-top: 3.5em;
134134 }
135135
136136 div.mw_clear {
137 - margin: 0;
138 - padding: 0;
 137+ margin: 0 0 0 0;
 138+ padding: 0 0 0 0;
139139 clear: both;
140140 }
141141
142142 .portlet {
143 - padding: 0;
144 - margin: 0;
 143+ padding: 0 0 0 0;
 144+ margin: 0 0 0 0;
145145 }
146146
147147 .portlet div.pBody {
148 - padding: 0 0 .5em;
 148+ padding: 0em 0 0.5em 0;
149149 }
150150
151151 textarea {
——@@ -167,9 +167,9 @@
168168 }
169169
170170 .portlet h5 {
171 - padding: .1em 0 .3em 1em;
172 - margin: 0;
173 - background-color: #ddd;
 171+ padding: 0.1em 0 0.3em 1em;
 172+ margin: 0 0 0 0;
 173+ background-color: #dddddd;
174174 font-weight: bold;
175175 border-bottom: solid 1px #3c78b5;
176176 height: 1.1em;
——@@ -177,7 +177,7 @@
178178
179179 .portlet ul {
180180 margin: 0 0 0 1.5em;
181 - padding: 0;
 181+ padding: 0 0 0 0;
182182 }
183183
184184 #mw_portlets .portlet ul {
——@@ -191,13 +191,13 @@
192192
193193 #p-cactions {
194194 height: 1.5em;
195 - padding: 0;
 195+ padding: 0 0 0 0;
196196 margin: 0 0 0 14em;
197197 }
198198
199199 #p-cactions div.pBody {
200 - margin: 0;
201 - padding: 0;
 200+ margin: 0 0 0 0;
 201+ padding: 0 0 0 0;
202202 }
203203
204204 #p-cactions a,
——@@ -208,13 +208,13 @@
209209
210210 #p-cactions ul {
211211 display: inline;
212 - margin: 0;
213 - padding: 0;
 212+ margin: 0 0 0 0;
 213+ padding: 0 0 0 0;
214214 }
215215
216216 #p-cactions li {
217 - margin: 0 .5em;
218 - padding: 0 .2em;
 217+ margin: 0 0.5em 0 0.5em;
 218+ padding: 0 0.2em 0 0.2em;
219219 display: block;
220220 float: left;
221221 height: 1.5em;
——@@ -222,14 +222,14 @@
223223 }
224224
225225 #p-cactions li.selected {
226 - background-color: #bbb;
 226+ background-color: #bbbbbb;
227227 }
228228
229229 #p-cactions li a,
230230 #p-cactions li a:hover,
231231 #p-cactions li a:visited {
232232 text-decoration: underline;
233 - color: #036;
 233+ color: #003366;
234234 }
235235
236236 #p-cactions li.selected a,
——@@ -251,15 +251,15 @@
252252 background-color: #f0f0f0;
253253 /* @embed */
254254 background: url(footer-grad.png) repeat-x 0 0;
255 - padding: 10px 1em 1em;
 255+ padding: 10px 1em 1em 1em;
256256 clear:both;
257 - color: #444;
 257+ color: #444444;
258258 }
259259
260260 #footer a,
261261 #footer a:hover,
262262 #footer a:visited {
263 - color: #444;
 263+ color: #444444;
264264 text-decoration: underline;
265265 }
266266
——@@ -270,13 +270,13 @@
271271 #footer li {
272272 display: inline;
273273 list-style-type: none;
274 - padding: 0;
275 - margin: 0;
 274+ padding: 0 0 0 0;
 275+ margin: 0 0 0 0;
276276 }
277277
278278 #footer ul {
279 - padding: 0;
280 - margin: 0;
 279+ padding: 0 0 0 0;
 280+ margin: 0 0 0 0;
281281 }
282282
283283 div.printfooter {
——@@ -284,7 +284,7 @@
285285 }
286286
287287 p {
288 - margin: 1em 0;
 288+ margin: 1em 0 1em 0;
289289 }
290290
291291 hr {
——@@ -292,7 +292,7 @@
293293 color: #aaa;
294294 background-color: #aaa;
295295 border: 0;
296 - margin: .2em 0;
 296+ margin: .2em 0 .2em 0;
297297 }
298298
299299 #contentSub {
——@@ -302,13 +302,13 @@
303303 }
304304
305305 #mw_portlets form {
306 - margin: 0;
307 - padding: 0;
 306+ margin: 0 0 0 0;
 307+ padding: 0 0 0 0;
308308 }
309309
310310 a {
311311 text-decoration: none;
312 - color: #036;
 312+ color: #003366;
313313 background: none;
314314 }
315315 a:visited {
——@@ -335,7 +335,7 @@
336336 }
337337
338338 h1, h2 {
339 - border-bottom: solid 1px #036;
 339+ border-bottom: solid 1px #003366;
340340 }
341341
342342 h1, h2, h3, h4, h5, h6 {
——@@ -344,15 +344,15 @@
345345
346346 #preftoc {
347347 width: 100%;
348 - margin: 0;
349 - padding: 0;
 348+ margin: 0 0 0 0;
 349+ padding: 0 0 0 0;
350350 height: 1.5em;
351351 clear: right;
352352 }
353353
354354 #preftoc li {
355 - margin: 0 .5em;
356 - padding: 0 .2em;
 355+ margin: 0 0.5em 0 0.5em;
 356+ padding: 0 0.2em 0 0.2em;
357357 display: block;
358358 float: left;
359359 height: 1.5em;
——@@ -360,9 +360,9 @@
361361 }
362362
363363 #preferences {
364 - margin: 0;
365 - padding: 0 1em 1em;
366 - border: solid 1px #bbb;
 364+ margin: 0 0 0 0;
 365+ padding: 0em 1em 1em 1em;
 366+ border: solid 1px #bbbbbb;
367367 clear: left; /* Multi-line toc should not push data to horizontally */
368368 }
369369
——@@ -389,14 +389,14 @@
390390 }
391391
392392 #preftoc li.selected {
393 - background-color: #bbb;
 393+ background-color: #bbbbbb;
394394 }
395395
396396 #preftoc li a,
397397 #preftoc li a:hover,
398398 #preftoc li a:visited {
399399 text-decoration: underline;
400 - color: #036;
 400+ color: #003366;
401401 }
402402
403403 #preftoc li.selected a,
——@@ -538,7 +538,7 @@
539539 margin: .5em 1.4em .8em 0;
540540 }
541541 img.thumbborder {
542 - border: 1px solid #ddd;
 542+ border: 1px solid #dddddd;
543543 }
544544 .mw-warning {
545545 border: 1px solid #aaa;
——@@ -549,22 +549,22 @@
550550
551551 #toc,
552552 .toc {
553 - margin: 0;
554 - padding: 0;
 553+ margin: 0 0 0 0;
 554+ padding: 0 0 0 0;
555555 border-spacing: 0;
556556 background-color: #f0f0f0;
557 - border: solid 1px #bbb;
 557+ border: solid 1px #bbbbbb;
558558 }
559559
560560 #toc tr, #toc td {
561 - margin: 0;
562 - padding: 0;
 561+ margin: 0 0 0 0;
 562+ padding: 0 0 0 0;
563563 }
564564
565565 #toctitle {
566566 border-bottom: solid 1px #3c78b5;
567 - background-color: #ddd;
568 - margin: 0;
 567+ background-color: #dddddd;
 568+ margin: 0 0 0 0;
569569 }
570570
571571 #toc h2,
——@@ -586,7 +586,7 @@
587587 .toc ul {
588588 list-style-type: none;
589589 list-style-image: none;
590 - margin: 0 1em;
 590+ margin: 0 1em 0 1em;
591591 padding-left: 0;
592592 text-align: left;
593593 }
——@@ -615,10 +615,10 @@
616616 }
617617
618618 .catlinks {
619 - border: solid 1px #bbb;
 619+ border: solid 1px #bbbbbb;
620620 background-color: #f0f0f0;
621 - padding: .1em .3em;
622 - margin: 0;
 621+ padding: 0.1em 0.3em 0.1em 0.3em;
 622+ margin: 0 0 0 0;
623623 }
624624
625625 #mw_header h1,
——@@ -672,9 +672,9 @@
673673
674674 .editExternally {
675675 border: 1px solid gray;
676 - background-color: #FFF;
 676+ background-color: #ffffff;
677677 padding: 3px;
678 - margin-top: .5em;
 678+ margin-top: 0.5em;
679679 float: left;
680680 font-size: small;
681681 text-align: center;
——@@ -699,7 +699,7 @@
700700
701701 /* @bug 1714 */
702702 input#wpSave, input#wpDiff {
703 - margin-right: .33em;
 703+ margin-right: 0.33em;
704704 }
705705
706706 #wpSave {
——@@ -768,7 +768,7 @@
769769 .templatesUsed { margin-top: 1.5em; }
770770
771771 .mw-summary-preview {
772 - margin: .1em 0;
 772+ margin: 0.1em 0;
773773 }
774774
775775 /* Friendlier slave lag warnings */
——@@ -779,18 +779,18 @@
780780 margin: 3px auto;
781781 }
782782 div.mw-lag-warn-normal {
783 - border: 1px solid #FC6;
784 - background-color: #FFC;
 783+ border: 1px solid #FFCC66;
 784+ background-color: #FFFFCC;
785785 }
786786 div.mw-lag-warn-high {
787787 font-weight: bold;
788 - border: 2px solid #F03;
789 - background-color: #FCC;
 788+ border: 2px solid #FF0033;
 789+ background-color: #FFCCCC;
790790 }
791791
792792 .MediaTransformError {
793793 background-color: #ccc;
794 - padding: .1em;
 794+ padding: 0.1em;
795795 }
796796 .MediaTransformError td {
797797 text-align: center;
——@@ -824,7 +824,7 @@
825825 }
826826
827827 #p-cactions li.new a {
828 - color: #c20;
 828+ color: #cc2200;
829829 }
830830
831831 span.subpages {
——@@ -834,7 +834,7 @@
835835
836836 pre {
837837 border: solid 1px #3c78b5;
838 - padding: .4em;
 838+ padding: 0.4em;
839839 background-color: #f0f0f0;
840840 }
841841
——@@ -844,29 +844,29 @@
845845
846846 .mw-topboxes {
847847 border-collapse: collapse;
848 - margin: 0 -1em 1em;
849 - padding: 0 0 8px;
 848+ margin: 0 -1em 1em -1em;
 849+ padding: 0 0 8px 0;
850850 /* @embed */
851851 background: url(footer-grad.png) repeat-x bottom left;
852852 }
853853
854854 .mw-topbox p {
855 - padding: 0;
856 - margin: 0;
 855+ padding: 0 0 0 0;
 856+ margin: 0 0 0 0;
857857 }
858858
859859 .mw-topbox {
860860 color: black;
861861 font-weight: bold;
862 - margin: 0;
863 - padding: 0 1em;
 862+ margin: 0 0 0 0;
 863+ padding: 0 1em 0 1em;
864864 vertical-align: middle;
865865 border-collapse: collapse;
866 - border-bottom: solid 1px #bbb;
 866+ border-bottom: solid 1px #bbbbbb;
867867 }
868868
869869 #siteSub {
870 - background-color: #ddd;
 870+ background-color: #dddddd;
871871 }
872872
873873 /* emulate center */
——@@ -881,11 +881,11 @@
882882
883883 /* table standards */
884884 .toccolours {
885 - border: 1px solid #bbb;
 885+ border: 1px solid #bbbbbb;
886886 background-color: #f0f0f0;
887 - border-spacing: 0;
888 - margin: 0;
889 - padding: 0;
 887+ border-spacing: 0pt;
 888+ margin: 0pt;
 889+ padding: 0pt;
890890 }
891891
892892 /* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93261Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.)diebuche13:01, 27 July 2011

Comments

#Comment by Hashar (talk | contribs)   18:13, 24 August 2011

we could have kept the optimizations such as: 

- padding: 0 0em 0 0em;
+ padding:0;

Marking ok anyway.

#Comment by Hashar (talk | contribs)   18:14, 24 August 2011

Meanwhile, does it really need 1.18? r93261 was never merged afaik

#Comment by Reedy (talk | contribs)   18:15, 24 August 2011

Duh!

Status & tagging log