r95321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95320‎ | r95321 | r95322 >
Date:19:38, 23 August 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* Removed no longer existing special pages (Special:Makebot and Special:MakeSysop)
* Removed mention of Filepath extension since this is now in core
Modified paths:
  • /trunk/phase3/maintenance/fuzz-tester.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fuzz-tester.php
@@ -139,9 +139,6 @@
140140
141141 // Install & enable Special Page extensions to increase code coverage. E.g.:
142142 require_once("extensions/Cite/SpecialCite.php");
143 - require_once("extensions/Filepath/SpecialFilepath.php");
144 - require_once("extensions/Makebot/Makebot.php");
145 - require_once("extensions/Makesysop/SpecialMakesysop.php");
146143 require_once("extensions/Renameuser/SpecialRenameuser.php");
147144 require_once("extensions/LinkSearch/LinkSearch.php");
148145 // --------- End ---------
@@ -1892,52 +1889,6 @@
18931890
18941891
18951892 /**
1896 - ** a test for Special:Makebot (extension Special page).
1897 - */
1898 -class specialMakebot extends pageTest {
1899 - function __construct() {
1900 - $this->pagePath = "index.php?title=Special:Makebot";
1901 -
1902 - $this->params = array (
1903 - "username" => wikiFuzz::chooseInput( array( "Nickj2", "192.168.0.2", wikiFuzz::makeFuzz( 1 ) ) ),
1904 - "dosearch" => wikiFuzz::chooseInput( array( "0", "1", "++--34234", wikiFuzz::makeFuzz( 2 ) ) ),
1905 - "grant" => wikiFuzz::chooseInput( array( "0", "1", "++--34234", wikiFuzz::makeFuzz( 2 ) ) ),
1906 - "comment" => wikiFuzz::chooseInput( array( "20398702394", "", wikiFuzz::makeFuzz( 2 ) ) ),
1907 - "token" => wikiFuzz::chooseInput( array( "20398702394", "", wikiFuzz::makeFuzz( 2 ) ) ),
1908 - );
1909 -
1910 - // sometimes we don't want to specify certain parameters.
1911 - if ( wikiFuzz::randnum( 2 ) == 0 ) unset( $this->params["dosearch"] );
1912 - if ( wikiFuzz::randnum( 2 ) == 0 ) unset( $this->params["grant"] );
1913 - if ( wikiFuzz::randnum( 5 ) == 0 ) unset( $this->params["token"] );
1914 - }
1915 -}
1916 -
1917 -
1918 -/**
1919 - ** a test for Special:Makesysop (extension Special page).
1920 - */
1921 -class specialMakesysop extends pageTest {
1922 - function __construct() {
1923 - $this->pagePath = "index.php?title=Special:Makesysop";
1924 -
1925 - $this->params = array (
1926 - "wpMakesysopUser" => wikiFuzz::chooseInput( array( "Nickj2", "192.168.0.2", wikiFuzz::makeFuzz( 1 ) ) ),
1927 - "action" => wikiFuzz::chooseInput( array( "0", "1", "++--34234", wikiFuzz::makeFuzz( 2 ) ) ),
1928 - "wpMakesysopSubmit" => wikiFuzz::chooseInput( array( "0", "1", "++--34234", wikiFuzz::makeFuzz( 2 ) ) ),
1929 - "wpEditToken" => wikiFuzz::chooseInput( array( "20398702394", "", wikiFuzz::makeFuzz( 2 ) ) ),
1930 - "wpSetBureaucrat" => wikiFuzz::chooseInput( array( "20398702394", "", wikiFuzz::makeFuzz( 2 ) ) ),
1931 - );
1932 -
1933 - // sometimes we don't want to specify certain parameters.
1934 - if ( wikiFuzz::randnum( 3 ) == 0 ) unset( $this->params["wpMakesysopSubmit"] );
1935 - if ( wikiFuzz::randnum( 3 ) == 0 ) unset( $this->params["wpEditToken"] );
1936 - if ( wikiFuzz::randnum( 3 ) == 0 ) unset( $this->params["wpSetBureaucrat"] );
1937 - }
1938 -}
1939 -
1940 -
1941 -/**
19421893 ** a test for Special:Renameuser (extension Special page).
19431894 */
19441895 class specialRenameuserPageTest extends pageTest {
@@ -2279,13 +2230,11 @@
22802231 case 37: return new profileInfo();
22812232 case 38: return new specialCitePageTest();
22822233 case 39: return new specialFilepathPageTest();
2283 - case 40: return new specialMakebot();
2284 - case 41: return new specialMakesysop();
2285 - case 42: return new specialRenameuserPageTest();
2286 - case 43: return new specialLinksearch();
2287 - case 44: return new specialCategoryTree();
2288 - case 45: return new api();
2289 - case 45: return new specialChemicalsourcesTest();
 2234+ case 40: return new specialRenameuserPageTest();
 2235+ case 41: return new specialLinksearch();
 2236+ case 42: return new specialCategoryTree();
 2237+ case 43: return new api();
 2238+ case 44: return new specialChemicalsourcesTest();
22902239 default: return new editPageTest();
22912240 }
22922241 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r95330Per Raymond, follow-up r95321: LinkSearch is in core tooialex20:02, 23 August 2011

Comments

#Comment by Raymond (talk | contribs)   19:55, 23 August 2011

LinkSearch is in core too.

Status & tagging log