r95193 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95192‎ | r95193 | r95194 >
Date:08:25, 22 August 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Followup r95172, use the getter instead of nonexistent member variable
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Outputs.php
@@ -117,7 +117,7 @@
118118 */
119119 static public function requireFromParserOutput( ParserOutput $parserOutput ) {
120120 // Note: we do not attempt to recover which head items where scripts here.
121 - self::$headItems = array_merge( (array)self::$headItems, (array)$parserOutput->headItems );
 121+ self::$headItems = array_merge( (array)self::$headItems, $parserOutput->getHeadItems() );
122122 if ( isset( $parserOutput->mModules ) ) {
123123 self::$headItems = array_merge( (array)self::$resourceModules, (array)$parserOutput->mModules );
124124 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r96844Follow-up to r95193 - re-added backward-compatibility for MW < 1.16yaron14:46, 12 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95172also support OutputPage/ParserOutput-agnostic script loading a la addScript()...mkroetzsch19:08, 21 August 2011