r95191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95190‎ | r95191 | r95192 >
Date:07:47, 22 August 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add new extension (r95180) to translatewiki.net
Add description message, tweak extension credits
Set 2 message to ignore
@Ashley: Would it work to "translate" http://$1.shoutbox.us/?LANG=US -> http://$1.shoutbox.us/?LANG=DE ? In this case the message could be optional instead
Modified paths:
  • /trunk/extensions/ShoutBox/ShoutBox.i18n.php (modified) (history)
  • /trunk/extensions/ShoutBox/ShoutBox.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -1258,6 +1258,9 @@
12591259 Short Url
12601260 aliasfile = ShortUrl/ShortUrl.alias.php
12611261
 1262+Shout Box
 1263+ignored = shoutbox-url, shoutbox-url-with-css
 1264+
12621265 Show Processlist
12631266 aliasfile = ShowProcesslist/ShowProcesslist.alias.php
12641267
Index: trunk/extensions/ShoutBox/ShoutBox.i18n.php
@@ -12,6 +12,7 @@
1313 * @author Jim R. Wilson
1414 */
1515 $messages['en'] = array(
 16+ 'shoutbox-desc' => 'Adds a parser function for embedding your own shoutbox',
1617 'shoutbox-missing-params' => 'ShoutBox is missing a required parameter.',
1718 'shoutbox-bad-params' => 'ShoutBox received a bad parameter.',
1819 'shoutbox-unparsable-param-string' => 'ShoutBox received the unparsable parameter string "<tt>$1</tt>".',
@@ -20,4 +21,4 @@
2122 'shoutbox-illegal-height' => 'ShoutBox received the illegal height parameter "$1".',
2223 'shoutbox-url' => 'http://$1.shoutbox.us/?LANG=US',
2324 'shoutbox-url-with-css' => 'http://$1.shoutbox.us/?LANG=US&extcss=$2',
24 -);
\ No newline at end of file
 25+);
Index: trunk/extensions/ShoutBox/ShoutBox.php
@@ -55,11 +55,12 @@
5656
5757 # Credits
5858 $wgExtensionCredits['parserhook'][] = array(
 59+ 'path' => __FILE__,
5960 'name' => 'ShoutBox',
60 - 'version' => '0.2.1',
 61+ 'version' => '0.2.2',
6162 'author' => array( 'Jim R. Wilson', 'Jack Phoenix' ),
6263 'url' => 'http://www.mediawiki.org/wiki/Extension:ShoutBox',
63 - 'description' => 'Adds a parser function for embedding your own shoutbox',
 64+ 'descriptionmsg' => 'shoutbox-desc',
6465 );
6566
6667 // Configuration settings

Follow-up revisions

RevisionCommit summaryAuthorDate
r95469fu r95191: Make 2 messages optinal per Jack's CRraymond10:02, 25 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95180new version of http://www.mediawiki.org/wiki/Extension:ShoutBoxashley22:24, 21 August 2011

Comments

#Comment by Jack Phoenix (talk | contribs)   11:56, 22 August 2011

Feel free to translate/localize the language code for those two messages, if you must; I have to say that the Finnish (fi) translation of ShoutBox.us is of the standard machine translation quality, so I'd rather pick the English interface over that gibberish (and unlike MediaWiki and its extensions, that website is not editable...I think), but it probably makes sense to have the extension link to a localized version where the localized version exists and the translation makes sense.

Status & tagging log