r95125 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95124‎ | r95125 | r95126 >
Date:09:40, 21 August 2011
Author:raymond
Status:ok (Comments)
Tags:lamecommitsummary 
Comment:
fu r95112/r95124: Remove version no from extension credits again.
There is a const already in class WikiHiero which I have not seen. Thanks to Niklas.
@maxsem: Maybe it is possible to move up this definition to make it available for $wgExtensionCredits?
Modified paths:
  • /trunk/extensions/wikihiero/wikihiero.php (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/wikihiero.php
——@@ -32,7 +32,6 @@
3333 'path' => __FILE__,
3434 'name' => 'WikiHiero',
3535 'author' => array( 'Guillaume Blanchard', 'Max Semenik' ),
36 - 'version' => '2.0',
3736 'url' => 'http://www.mediawiki.org/wiki/Extension:WikiHiero',
3837 'descriptionmsg' => 'wikihiero-desc',
3938 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95112WikiHiero: created a special page to play with markup. Exactly what index.php...maxsem20:40, 20 August 2011
r95124fu r95112: Add version no., add Max as author for the rewrite...raymond08:56, 21 August 2011

Comments

#Comment by P858snake (talk | contribs)   10:04, 21 August 2011

0.2.15 was the version number last used by the author on the talk page, how about we start with 0.2.16 or just at 1.0 since this apparently a cleanup and possibly a rewrite.

#Comment by P858snake (talk | contribs)   10:04, 21 August 2011

s/talk page/ext page/

#Comment by Nikerabbit (talk | contribs)   10:09, 21 August 2011

I already started this discussion at r95064.

Status & tagging log