r94917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94916‎ | r94917 | r94918 >
Date:18:50, 18 August 2011
Author:preilly
Status:resolved (Comments)
Tags:
Comment:
add addtional wikipedia specific css selector for template — remember that $wgMFRemovableClasses can be used for non-wikipedia sites
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
——@@ -55,7 +55,7 @@
5656 $wgMFRemovableClasses = array();
5757
5858 class ExtMobileFrontend {
59 - const VERSION = '0.5.34';
 59+ const VERSION = '0.5.35';
6060
6161 /**
6262 * @var DOMDocument
——@@ -104,6 +104,7 @@
105105 '.metadata mbox-small',
106106 '.metadata plainlinks ambox ambox-content',
107107 '.metadata plainlinks ambox ambox-move',
 108+ '.metadata plainlinks ambox ambox-style',
108109 'form',
109110 'div.sister-project',
110111 'script',

Follow-up revisions

RevisionCommit summaryAuthorDate
r94918mft r94917preilly18:51, 18 August 2011
r94935fix for r94917preilly20:28, 18 August 2011

Comments

#Comment by MZMcBride (talk | contribs)   20:15, 18 August 2011

This revision just compounds previous bad revisions and should be reverted. There's no question that this "solution" is not scalable or adaptable. There are better alternatives available and those should be implemented instead of chasing every English Wikipedia-specific CSS style that you happen to haphazardly come across.

#Comment by 😂 (talk | contribs)   20:17, 18 August 2011

I introduced $wgMFRemovableClasses for the WMF sites, so we don't have to hardcode this sort of thing...

#Comment by MZMcBride (talk | contribs)   20:30, 18 August 2011

$wgMFRemovableClasses requires sysadmin intervention to adjust CSS display settings that are largely controlled by local administrators. I don't think anyone has raised a valid objection to handling this the same way that print styling is handled, via a "Mobile.css" page. That allows for any local admin to adjust this as necessary, on-wiki, in a similar way to how global CSS is defined currently ("Skin.css" or "Common.css").

I see absolutely no reason that hardcoding specific English Wikipedia-specific classes or using a global configuration variable is a good idea here. It's baffling to me that this is even a point of contention, but I'm obviously involved at this point.

#Comment by TheDJ (talk | contribs)   20:47, 18 August 2011

I fully agree with MZMcBride

#Comment by 😂 (talk | contribs)   21:06, 18 August 2011

I don't disagree at all. I was just saying that I've already worked around the hardcoding to some degree, and there's no reason to further it.

#Comment by Preilly (talk | contribs)   20:29, 18 August 2011

Those have now been moved to $wgMFRemovableClasses in r94935.

Status & tagging log