r94890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94889‎ | r94890 | r94891 >
Date:13:32, 18 August 2011
Author:churchofemacs
Status:reverted (Comments)
Tags:
Comment:
link to special:userlogin
Modified paths:
  • /trunk/extensions/SecurePoll/SecurePoll.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SecurePoll/SecurePoll.i18n.php
——@@ -72,7 +72,7 @@
7373 'securepoll-api-invalid-params' => 'Invalid parameters.',
7474 'securepoll-api-no-user' => 'No user was found with the given ID.',
7575 'securepoll-api-token-mismatch' => 'Security token mismatch, cannot log in.',
76 - 'securepoll-not-logged-in' => 'You must log in to vote in this election',
 76+ 'securepoll-not-logged-in' => 'You must [[Special:Userlogin|log in]] to vote in this election. If you do not yet have an account, you can [[Special:Userlogin/signup|create one]].',
7777 'securepoll-too-few-edits' => 'Sorry, you cannot vote. You need to have made at least $1 {{PLURAL:$1|edit|edits}} to vote in this election, you have made $2.',
7878 'securepoll-too-new' => 'Sorry, you cannot vote. Your account needs to have been registered before $1 to vote in this election, you registered on $2.',
7979 'securepoll-blocked' => 'Sorry, you cannot vote in this election if you are currently blocked from editing.',

Sign-offs

UserFlagDate
Lcawteinspected16:50, 18 August 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r98127Revert r94890: per CR, this message isn't necessarily correctdemon12:56, 26 September 2011

Comments

#Comment by Nemo bis (talk | contribs)   07:50, 19 August 2011

I'm not sure that this change makes the message less confusing: WMF usage of the extension is particularly complex because it relies on a third party hence it required this rephrasement («You've not been recognized by the system. Make sure that you've followed the instructions on [...] and that you've enabled cookies for this domain»); but in general, while it's true that logging in is a requirement, it's usually not true that every registered user can vote, so inviting unregistered users to register (implying that they'll then be able to vote) seems confusing.

On a side note, "[having an] account" is not consistently translated, at least in Italian, where it may need to be translated as "being registered", and the usage of an adjective makes the message not gender neutral and would require {{GENDER}}.

Status & tagging log