r94839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94838‎ | r94839 | r94840 >
Date:22:43, 17 August 2011
Author:preilly
Status:ok
Tags:
Comment:
fix for r94262 remove use of filter_* functions
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -55,7 +55,7 @@
5656 $wgMFRemovableClasses = array();
5757
5858 class ExtMobileFrontend {
59 - const VERSION = '0.5.33';
 59+ const VERSION = '0.5.34';
6060
6161 /**
6262 * @var DOMDocument
@@ -357,7 +357,7 @@
358358
359359 private function getBaseDomain() {
360360 //Validates value as IP address
361 - if( !filter_var( $_SERVER['HTTP_HOST'], FILTER_VALIDATE_IP ) ) {
 361+ if( !IP::isValid( $_SERVER['HTTP_HOST'] ) ) {
362362 $domainParts = explode( '.', $_SERVER['HTTP_HOST'] );
363363 $domainParts = array_reverse( $domainParts );
364364 //Although some browsers will accept cookies without the initial ., » RFC 2109 requires it to be included.

Follow-up revisions

RevisionCommit summaryAuthorDate
r94840mft r94839preilly22:43, 17 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94262add Opt-In and Opt-Out base domain cookie supportpreilly17:50, 11 August 2011

Status & tagging log