r94779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94778‎ | r94779 | r94780 >
Date:17:17, 17 August 2011
Author:preilly
Status:resolved (Comments)
Tags:
Comment:
fix for bug 30421
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
——@@ -49,7 +49,7 @@
5050 $wgHooks['SkinTemplateOutputPageBeforeExec'][] = array( &$wgExtMobileFrontend, 'addMobileFooter' );
5151
5252 class ExtMobileFrontend {
53 - const VERSION = '0.5.31';
 53+ const VERSION = '0.5.32';
5454
5555 /**
5656 * @var DOMDocument
——@@ -95,6 +95,8 @@
9696 'div.stub', # stub warnings
9797 'table.metadata', # ugly metadata
9898 '.metadata mbox-small',
 99+ '.metadata plainlinks ambox ambox-content',
 100+ '.metadata plainlinks ambox ambox-move',
99101 'form',
100102 'div.sister-project',
101103 'script',

Follow-up revisions

RevisionCommit summaryAuthorDate
r94780mft r94779preilly17:18, 17 August 2011

Comments

#Comment by MZMcBride (talk | contribs)   17:40, 17 August 2011

This isn't a scalable solution and this just adds further English Wikipedia-specific code to what's supposed to be a generic extension. I recommend reverting this.

#Comment by Preilly (talk | contribs)   17:41, 17 August 2011

Well, we need to strip those sections from the wikipedia site. I'm not going to revert it.

#Comment by MaxSem (talk | contribs)   17:45, 17 August 2011

Noobody said that you should revert it, however improving it to be configurable (and work on Wikimedia projects other than enwiki!) would be great.

#Comment by MZMcBride (talk | contribs)   17:47, 17 August 2011

What's the reason for removing the notices? They're important notices about the state of the article and its contents.

If they must be removed, they should be removed in a way that's clean and not English Wikipedia-specific.

Status & tagging log