r94738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94737‎ | r94738 | r94739 >
Date:09:55, 17 August 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Self-revert r79892: only got one opposition and apparently too hairy for anyone else to comment :)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -231,8 +231,6 @@
232232 * If an edit summary exceeds 250 bytes and is truncated, add an ellipse.
233233 * (bug 26638) Database error pages display correctly in RTL languages.
234234 * (bug 26187) Confirmrecreate no longer parses the edit summary.
235 -* (bug 25506) Exception is thrown if OutputPage::parse is called inside a tag
236 - hook, which would reset parser state.
237235 * (bug 26208) Mark directionality of some interlanguage links.
238236 * (bug 26034) Make the "View / Read" tab in content_navigation style tabs remain
239237 selected when the action is "purge".
Index: trunk/phase3/includes/OutputPage.php
@@ -1465,13 +1465,6 @@
14661466 * @return String: HTML
14671467 */
14681468 public function parse( $text, $linestart = true, $interface = false, $language = null ) {
1469 - // Check one for one common cause for parser state resetting
1470 - $callers = wfGetAllCallers( 10 );
1471 - if ( strpos( $callers, 'Parser::extensionSubstitution' ) !== false ) {
1472 - throw new MWException( "wfMsg* function with parsing cannot be used " .
1473 - "inside a tag hook. Should use parser->recursiveTagParse() instead" );
1474 - }
1475 -
14761469 global $wgParser;
14771470
14781471 if( is_null( $this->getTitle() ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r95632MFT to REL1_18...hashar17:57, 28 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79892* (bug 25506) Exception is thrown if OutputPage::parse is called inside a tag...nikerabbit12:46, 9 January 2011

Comments

#Comment by Hashar (talk | contribs)   15:42, 17 August 2011

tagging for 1.18

Status & tagging log