r94729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94728‎ | r94729 | r94730 >
Date:06:16, 17 August 2011
Author:nagelp
Status:resolved (Comments)
Tags:
Comment:
Changed version to 1.1, use new addExtensionUpdate, modify one index in the database
Modified paths:
  • /trunk/extensions/Notificator/Notificator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Notificator/Notificator.php
@@ -9,7 +9,7 @@
1010 'path' => __FILE__, // Magic so that svn revision number can be shown
1111 'name' => 'Notificator',
1212 'descriptionmsg' => 'notificator-desc',
13 - 'version' => '1.0.2',
 13+ 'version' => '1.1',
1414 'author' => 'Patrick Nagel',
1515 'url' => "http://www.mediawiki.org/wiki/Extension:Notificator",
1616 );
@@ -31,9 +31,11 @@
3232 // Setting default here, to avoid register_globals vulnerabilites
3333 $ngFromAddress = $wgPasswordSenderName . '<' . $wgPasswordSender . '>';
3434
35 -function notificator_AddDatabaseTable() {
36 - global $wgExtNewTables;
37 - $wgExtNewTables[] = array( 'notificator', dirname( __FILE__ ) . '/Notificator.sql' );
 35+function notificator_AddDatabaseTable( $updater ) {
 36+ $updater->addExtensionUpdate( array( 'addTable', 'notificator',
 37+ dirname( __FILE__ ) . '/Notificator.sql', true ) );
 38+ $updater->addExtensionUpdate( array( 'modifyField', 'notificator', 'receiver_email',
 39+ dirname( __FILE__ ) . '/Notificator.patch.sql', true ) );
3840 return true;
3941 }
4042

Follow-up revisions

RevisionCommit summaryAuthorDate
r94739Followup to 94729 - forgot to add the Notificator.patch.sqlnagelp10:38, 17 August 2011

Comments

#Comment by Nikerabbit (talk | contribs)   10:32, 17 August 2011

Please record the follow-ups where the index was actually modified and filename changed.

#Comment by Nikerabbit (talk | contribs)   10:41, 17 August 2011

Looks like one sql file is actually missing.

#Comment by Patrick Nagel (talk | contribs)   10:46, 17 August 2011

Yes, I had forgotten to 'svn add' the actual SQL patch. I did it just now in r94739, but don't know how to mark it as follow-up.

#Comment by Nikerabbit (talk | contribs)   16:08, 17 August 2011

Just mention the revision number in the commit message like you did, prefixed with letter r.

Status & tagging log