r94575 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r94574‎ \| r94575 \| r94576 >
Date:	21:18, 15 August 2011
Author:	hashar
Status:	reverted (Comments)
Tags:
Comment:	avoid playing with $_SERVER in test for now fu r94558
Modified paths:	/trunk/phase3/tests/phpunit/includes/ProxyTools/wfGetIPTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/ProxyTools/wfGetIPTest.php
—	—	@@ -35,6 +35,9 @@
36	36	$wgCommandLineMode = $save;
37	37	}
38	38
	39	+ /**
	40	+ * @group Broken
	41	+ */
39	42	function testGetFromServerRemoteAddr() {
40	43	global $_SERVER;
41	44	$save = null;

Revision	Commit summary	Author	Date
r94638	Tests for wfGetIP() follow up r89407...	hashar	14:15, 16 August 2011

Revision	Commit summary	Author	Date
r94558	Tests for wfGetIP() follow up r89407...	hashar	20:16, 15 August 2011

#Comment by Brion VIBBER (talk | contribs) 21:21, 15 August 2011

Hashar, can you pop onto #mediawiki so we can check up with you about this test stuff? Some odd borkage.

#Comment by Brion VIBBER (talk | contribs) 21:56, 15 August 2011

[we got that worked out now, at least enough to keep the test marked off]

14:15, 16 August 2011 Hashar (talk | contribs) changed the status of r94575 [removed: new added: reverted]