r94540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94539‎ | r94540 | r94541 >
Date:18:19, 15 August 2011
Author:raindrift
Status:ok
Tags:
Comment:
checking for existence of mLocalFile in stashFile() was inverted
followup to r94536
Modified paths:
  • /trunk/phase3/includes/upload/UploadFromStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromStash.php
@@ -103,7 +103,7 @@
104104 * There is no need to stash the image twice
105105 */
106106 public function stashFile( $key = null ) {
107 - if ( !$this->mLocalFile ) {
 107+ if ( $this->mLocalFile ) {
108108 return $this->mLocalFile;
109109 }
110110 return parent::stashFile( $key );

Sign-offs

UserFlagDate
Nikerabbitinspected11:02, 16 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94536Fixed incorrect usage of || operator, added test...raindrift18:10, 15 August 2011

Status & tagging log