r94539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94538‎ | r94539 | r94540 >
Date:18:17, 15 August 2011
Author:raindrift
Status:ok
Tags:
Comment:
cleaned up database query, doesn't have to be aware of column names anymore (thanks Catrope!)
followup to r92009
Modified paths:
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadStash.php
@@ -485,22 +485,7 @@
486486 return false;
487487 }
488488
489 - $this->fileMetadata[$key] = array(
490 - 'us_user' => $row->us_user,
491 - 'us_key' => $row->us_key,
492 - 'us_orig_path' => $row->us_orig_path,
493 - 'us_path' => $row->us_path,
494 - 'us_size' => $row->us_size,
495 - 'us_sha1' => $row->us_sha1,
496 - 'us_mime' => $row->us_mime,
497 - 'us_media_type' => $row->us_media_type,
498 - 'us_image_width' => $row->us_image_width,
499 - 'us_image_height' => $row->us_image_height,
500 - 'us_image_bits' => $row->us_image_bits,
501 - 'us_source_type' => $row->us_source_type,
502 - 'us_timestamp' => $row->us_timestamp,
503 - 'us_status' => $row->us_status
504 - );
 489+ $this->fileMetadata[$key] = (array)$row;
505490
506491 return true;
507492 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92009Refactored UploadStash and related classes to use the database for file metad...raindrift21:11, 12 July 2011

Status & tagging log