r94497 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94496‎ | r94497 | r94498 >
Date:10:06, 15 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
minor JS-fix for IE
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php
@@ -353,7 +353,7 @@
354354 $wgOut->addScriptFile( "$smwgScriptPath/skins/elastic/jquery.elastic.source.js" );
355355 $javascript = <<<EOT
356356 jQuery(document).ready(function(){
357 - jQuery('#querybox').elastic();
 357+// jQuery('#querybox').elastic();
358358 jQuery('#querybox').trigger('update');
359359 });
360360 EOT;
@@ -908,7 +908,7 @@
909909 var children = new_div.getElementsByTagName('*');
910910 var x;
911911 for (x = 0; x < children.length; x++) {
912 - if (children[x].for) children[x].for="display"+num_elements;
 912+ if (jQuery(children[x]).attr('for')) jQuery(children[x]).attr('for',"display"+num_elements);
913913 if (children[x].name){
914914 children[x].id = children[x].name.replace(/_num/, ''+num_elements);
915915 children[x].name = children[x].name.replace(/_num/, '[' + num_elements + ']');
@@ -944,7 +944,7 @@
945945 var children = new_div.getElementsByTagName('*');
946946 var x;
947947 for (x = 0; x < children.length; x++) {
948 - if (children[x].for) children[x].for="display"+num_elements;
 948+ if (jQuery(children[x]).attr('for')) jQuery(children[x]).attr('for',"display"+num_elements);
949949 if (children[x].name){
950950 children[x].id = children[x].name.replace(/_num/, ''+num_elements);
951951 children[x].name = children[x].name.replace(/_num/, '[' + num_elements + ']');
@@ -980,7 +980,7 @@
981981 var children = new_div.getElementsByTagName('*');
982982 var x;
983983 for (x = 0; x < children.length; x++) {
984 - if (children[x].for) children[x].for="display"+num_elements;
 984+ if (jQuery(children[x]).attr('for')) jQuery(children[x]).attr('for',"display"+num_elements);
985985 if (children[x].name){
986986 children[x].id = children[x].name.replace(/_num/, ''+num_elements);
987987 children[x].name = children[x].name.replace(/_num/, '[' + num_elements + ']');
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css
@@ -173,7 +173,7 @@
174174 }
175175
176176 .smwquisortlabel{
177 - width: 12em;
 177+ width: 15em;
178178 float: left;
179179 }
180180 /* search, browse, RDF icons */

Follow-up revisions

RevisionCommit summaryAuthorDate
r94500follow-up r94497devayon11:09, 15 August 2011