r94479 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94478‎ | r94479 | r94480 >
Date:20:13, 14 August 2011
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Use Html::element instead.

Follow up to r94385
Modified paths:
  • /trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php
@@ -83,7 +83,7 @@
8484 return '';
8585 }
8686 foreach( $tagSet as $attr ){
87 - $s.= Html::rawElement($tagName, $attr, '');
 87+ $s .= Html::element( $tagName, $attr);
8888 }
8989 return $s;
9090 }
@@ -211,8 +211,7 @@
212212 'height' => $height,
213213 // Get the correct size:
214214 'poster' => $posterUrl,
215 - 'alt' => $this->file->getTitle()->getText(),
216 -
 215+
217216 // Note we set controls to true ( for no-js players ) when mwEmbed rewrites the interface
218217 // it updates the controls attribute of the embed video
219218 'controls'=> 'true',

Sign-offs

UserFlagDate
Simetricalinspected21:40, 18 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94385Html5 player should be able to output actual valid Html5.hartman21:13, 12 August 2011

Comments

#Comment by Simetrical (talk | contribs)   19:21, 15 August 2011

You're missing a space before the closing ")", but more importantly, you didn't explain your removal of the alt text here.

#Comment by TheDJ (talk | contribs)   21:12, 18 August 2011

Hmm, the alt text thing was supposed to be a separate commit. But the http://www.w3.org/TR/html5/video.html tags audio and video will explicitly NOT support alt. For the blind, alternative audio tracks are required to be provided for video accessibility, and for the deaf caption tracks or sign language overlays should be provided in order to be conforming with accessibility guidelines.

#Comment by Simetrical (talk | contribs)   21:40, 18 August 2011

Ah, I see. Yeah, there's no alt text for video/audio, removing that is correct.

Status & tagging log