r94466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94465‎ | r94466 | r94467 >
Date:18:14, 14 August 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Per CR comment on r92358, add a special page aliases file for WikimediaIncubator
Modified paths:
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.alias.php (added) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.php
——@@ -68,6 +68,7 @@
6969 $wgRemoveGroups['bureaucrat']['test-sysop'] = true;
7070
7171 $wgExtensionMessagesFiles['WikimediaIncubator'] = $dir . 'WikimediaIncubator.i18n.php';
 72+$wgExtensionAliasesFiles['WikimediaIncubator'] = $dir . 'WikimediaIncubator.alias.php';
7273
7374 /* Special:ViewUserLang */
7475 $wgAutoloadClasses['SpecialViewUserLang'] = $dir . 'SpecialViewUserLang.php';
Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.alias.php
——@@ -0,0 +1,16 @@
 2+<?php
 3+/**
 4+ * Aliases for Special:Gadgets
 5+ *
 6+ * @file
 7+ * @ingroup Extensions
 8+ */
 9+
 10+$specialPageAliases = array();
 11+
 12+/** English (English) */
 13+$specialPageAliases['en'] = array(
 14+ 'ViewUserLang' => array( 'ViewUserLang' ),
 15+ 'MyMainPage' => array( 'MyMainPage' ),
 16+ 'RandomByTest' => array( 'RandomByTest' ),
 17+);
Property changes on: trunk/extensions/WikimediaIncubator/WikimediaIncubator.alias.php
___________________________________________________________________
Added: svn:eol-style
118 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r94481Fix copypaste snafu in r94466catrope20:53, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92358Add a simple special page that goes to the main page of your test wiki.robin14:51, 16 July 2011

Comments

#Comment by Siebrand (talk | contribs)   20:47, 14 August 2011

Comment on the alias file is incorrect (refers to Gadgets)

#Comment by SPQRobin (talk | contribs)   21:22, 14 August 2011

Didn't know alias files were absolutely needed, but anyway thanks for adding them.

#Comment by Catrope (talk | contribs)   21:36, 14 August 2011

I'm not sure about that either, but Raymond said they should be there and he's a TranslateWiki guy, so what can you do :)

#Comment by Krinkle (talk | contribs)   21:40, 14 August 2011

I don't think they're technically needed but last I tried without I got E_NOTICE on SpecialSpecialPages. Also, TranslateWiki needs it to add translations (the Translator-export script is not allowed to create new files afaik)

#Comment by SPQRobin (talk | contribs)   21:47, 14 August 2011

Btw, to translatewiki admins: it's not really worth adding this file, as it is most likely only used on Incubator (or wikis with English as default language in general). Plus, two of the special pages are redirects anyway.

Status & tagging log