r94450 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94449‎ | r94450 | r94451 >
Date:10:33, 14 August 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Forport from 1.17wmf1 to 1.18
r94252 Wrap site_stats update in a begin()/commit()
Modified paths:
  • /branches/REL1_18/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/filerepo/LocalFile.php
——@@ -969,8 +969,10 @@
970970 } else {
971971 # This is a new file
972972 # Update the image count
 973+ $dbw->begin();
973974 $site_stats = $dbw->tableName( 'site_stats' );
974975 $dbw->query( "UPDATE $site_stats SET ss_images=ss_images+1", __METHOD__ );
 976+ $dbw->commit();
975977 }
976978
977979 $descTitle = $this->getTitle();
Property changes on: branches/REL1_18/phase3/includes/filerepo/LocalFile.php
___________________________________________________________________
Added: svn:mergeinfo
978980 Merged /branches/sqlite/includes/filerepo/LocalFile.php:r58211-58321
979981 Merged /trunk/phase3/includes/filerepo/LocalFile.php:r92634,92762,92791,92854,92958,93141,93303
980982 Merged /branches/new-installer/phase3/includes/filerepo/LocalFile.php:r43664-66004
981983 Merged /branches/wmf-deployment/includes/filerepo/LocalFile.php:r53381
982984 Merged /branches/wmf/1.17wmf1/includes/filerepo/LocalFile.php:r94252
983985 Merged /branches/REL1_15/phase3/includes/filerepo/LocalFile.php:r51646

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94252Wrap site_stats update in a begin()/commit() to see if this helps...demon15:29, 11 August 2011

Comments

#Comment by 😂 (talk | contribs)   15:49, 14 August 2011

This should go in trunk first then be merged to 1.18

#Comment by Hashar (talk | contribs)   10:20, 15 August 2011

Well the original revision is still tagged 'trunk' :-)

Status & tagging log