r94448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94447‎ | r94448 | r94449 >
Date:09:37, 14 August 2011
Author:maxsem
Status:ok
Tags:
Comment:
ApiParamInfo: if no help URLs are available, return an empty array instead of array with one empty element
Modified paths:
  • /trunk/phase3/includes/api/ApiParamInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiParamInfo.php
@@ -117,6 +117,9 @@
118118 }
119119
120120 $retval['helpurls'] = (array)$obj->getHelpUrls();
 121+ if ( isset( $retval['helpurls'][0] ) && $retval['helpurls'][0] === false ) {
 122+ $retval['helpurls'] = array();
 123+ }
121124 $result->setIndexedTagName( $retval['helpurls'], 'helpurl' );
122125
123126 $retval['allexamples'] = $examples;

Follow-up revisions

RevisionCommit summaryAuthorDate
r94548Followup r92430 per CR, like r94448reedy18:56, 15 August 2011

Status & tagging log