r94443 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94442‎ | r94443 | r94444 >
Date:06:59, 14 August 2011
Author:vasilievvv
Status:ok (Comments)
Tags:
Comment:
Make certain members of the SyntaxHighlight_GeSHi class public, so other
extensions may use it.
Modified paths:
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
——@@ -240,7 +240,7 @@
241241 * @param string $lang
242242 * @return GeSHi
243243 */
244 - private static function prepare( $text, $lang ) {
 244+ public static function prepare( $text, $lang ) {
245245 self::initialise();
246246 $geshi = new GeSHi( $text, $lang );
247247 if( $geshi->error() == GESHI_ERROR_NO_SUCH_LANG ) {
——@@ -260,7 +260,7 @@
261261 * @param GeSHi $geshi
262262 * @return string
263263 */
264 - private static function buildHeadItem( $geshi ) {
 264+ public static function buildHeadItem( $geshi ) {
265265 global $wgUseSiteCss, $wgSquidMaxage;
266266 $lang = $geshi->language;
267267 $css = array();
——@@ -378,4 +378,4 @@
379379 return self::hSpecialVersion_GeSHi( $extensionTypes );
380380 }
381381
382 -}
\ No newline at end of file
 382+}

Comments

#Comment by Nikerabbit (talk | contribs)   13:02, 14 August 2011

Use for what purpose?

#Comment by MaxSem (talk | contribs)   13:04, 14 August 2011

Guess for highlighting stuff for that extension. I can even guess for which:)

#Comment by VasilievVV (talk | contribs)   14:15, 14 August 2011

r94459

Status & tagging log