r94362 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94361‎ | r94362 | r94363 >
Date:16:50, 12 August 2011
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Fix for r94289: we want to skip rows with non-empty sha1, not non-NULL (which is impossible)
Modified paths:
  • /trunk/phase3/maintenance/populateRevisionSha1.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/populateRevisionSha1.php
——@@ -68,7 +68,7 @@
6969 while ( $blockEnd <= $end ) {
7070 $this->output( "...doing $idCol from $blockStart to $blockEnd\n" );
7171 $cond = "$idCol BETWEEN $blockStart AND $blockEnd
72 - AND $idCol IS NOT NULL AND {$prefix}_sha1 IS NOT NULL";
 72+ AND $idCol IS NOT NULL AND {$prefix}_sha1 != ''";
7373 $res = $db->select( $table, '*', $cond, __METHOD__ );
7474
7575 $db->begin();

Follow-up revisions

RevisionCommit summaryAuthorDate
r94370* Added LoggedUpdateMaintenance subclass...aaron19:11, 12 August 2011
r94541Revert r94289, r94290, r94294, r94333, r94345, r94362, r94370 -- core schema ...brion18:24, 15 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94289* Added rev_sha1 and ar_sha1 columns to revision/archive tables (useful for b......aaron21:52, 11 August 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   18:55, 12 August 2011

This is backwards, fixing in the next commit.

#Comment by Brion VIBBER (talk | contribs)   18:27, 15 August 2011

undiscussed core schema change, reverted in r94541.

Status & tagging log