r94216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94215‎ | r94216 | r94217 >
Date:00:17, 11 August 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r94211

Bug 30315 - Declaration of FauxResponse::setcookie() should be compatible with that of WebResponse::setcookie()
Modified paths:
  • /trunk/phase3/includes/WebResponse.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebResponse.php
——@@ -135,7 +135,7 @@
136136 * @param $value String: value to give cookie
137137 * @param $expire Int: number of seconds til cookie expires
138138 */
139 - public function setcookie( $name, $value, $expire = 0 ) {
 139+ public function setcookie( $name, $value, $expire = 0, $prefix = null, $domain = null ) {
140140 $this->cookies[$name] = $value;
141141 }
142142

Follow-up revisions

RevisionCommit summaryAuthorDate
r101106MFT r94211,r94216: setcookie() tweaks for overriding the path, etc.demon01:02, 28 October 2011
r101107MFT r94211,r94216: setcookie() tweaks for overriding the path, etc.demon01:02, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94211Allow overriding $wgCookiePrefix and $wgCookieDomain in WebResponse::setcooki...demon23:27, 10 August 2011

Comments

#Comment by 😂 (talk | contribs)   00:19, 11 August 2011

I know this isn't the fault of this rev, but FauxResponse should probably handle $prefix (and $wgCookiePrefix) properly.

Status & tagging log