r94199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94198‎ | r94199 | r94200 >
Date:21:15, 10 August 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Merge r93797 to trunk, in a somewhat modified form: clamp expiries for memcached to 30 days, higher values give trouble apparently
Modified paths:
  • /trunk/phase3/includes/objectcache/MemcachedClient.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/objectcache/MemcachedClient.php
——@@ -948,6 +948,12 @@
949949 } else {
950950 $this->stats[$cmd] = 1;
951951 }
 952+
 953+ // Memcached doesn't seem to handle very high TTL values very well,
 954+ // so clamp them at 30 days
 955+ if ( $exp > 2592000 ) {
 956+ $exp = 2592000;
 957+ }
952958
953959 $flags = 0;
954960

Follow-up revisions

RevisionCommit summaryAuthorDate
r99061MFT r94199reedy23:41, 5 October 2011
r99106Per Domas, reinstate <1e9 check that was dropped in r94199. Also document wha...catrope14:07, 6 October 2011
r99980REL1_18 MFT r93726, r94199, r96437, r96438, r696579, r98235, r98734reedy22:13, 16 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93737avoid not caching data because of stupid memcached heuristics on ttl valuemidom12:47, 2 August 2011

Comments

#Comment by Reedy (talk | contribs)   22:33, 10 August 2011

r93737 even

Status & tagging log