r94088 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94087‎ | r94088 | r94089 >
Date:20:44, 8 August 2011
Author:raindrift
Status:ok (Comments)
Tags:
Comment:
Updated to use the copy of Jasmine in core, including extensions added in r93908
Modified paths:
  • /trunk/extensions/UploadWizard/test/jasmine/SpecRunner.html (modified) (history)
  • /trunk/extensions/UploadWizard/test/jasmine/lib (deleted) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/test/jasmine/SpecRunner.html
——@@ -3,13 +3,12 @@
44 <html>
55 <head>
66 <title>Jasmine Test Runner</title>
7 - <link rel="stylesheet" type="text/css" href="lib/jasmine-1.0.1/jasmine.css">
8 - <script type="text/javascript" src="lib/jasmine-1.0.1/jasmine.js"></script>
9 - <script type="text/javascript" src="lib/jasmine-1.0.1/jasmine-html.js"></script>
 7+ <link rel="stylesheet" type="text/css" href="../../../../tests/jasmine/lib/jasmine-1.0.1/jasmine.css">
 8+ <script type="text/javascript" src="../../../../tests/jasmine/lib/jasmine-1.0.1/jasmine.js"></script>
 9+ <script type="text/javascript" src="../../../../tests/jasmine/lib/jasmine-1.0.1/jasmine-html.js"></script>
1010
1111 <!-- include source files here... -->
12 - <script type="text/javascript" src="../../../../load.php?debug=true&lang=en&modules=jquery%7Cmediawiki&only=scripts&skin=vector"></script>
13 - <script type="text/javascript" src="lib/appendto-jquery-mockjax/jquery.mockjax.js"></script>
 12+ <script type="text/javascript" src="../../../../load.php?debug=true&lang=en&modules=jquery%7Cmediawiki%7Cjquery.mockjax&only=scripts&skin=vector"></script>
1413
1514 <script type="text/javascript" src="../../../../resources/mediawiki/mediawiki.js"></script>
1615 <script type="text/javascript" src="../../../../resources/mediawiki.language/mediawiki.language.js"></script>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93908Adding jquery plugins that UploadWizard and jQueryMsg need for Jasmine testsraindrift20:43, 4 August 2011

Comments

#Comment by Reedy (talk | contribs)   21:13, 8 August 2011 
+  <script type="text/javascript" src="../../../../tests/jasmine/lib/jasmine-1.0.1/jasmine-html.js"></script>

God that looks awful

#Comment by Raindrift (talk | contribs)   18:58, 15 August 2011

Yeah. It's like morse code or something.

Is there a better way?

#Comment by Reedy (talk | contribs)   19:27, 15 August 2011

We can use $IP in php code, but I don't think there is...

#Comment by NeilK (talk | contribs)   13:59, 22 August 2011

This is nasty and won't work for some exotic setups but it's okay for us, for now. Should we have the equivalent of $IP in JS-land now?

Status & tagging log