r94079 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94078‎ | r94079 | r94080 >
Date:19:57, 8 August 2011
Author:kipcool
Status:ok (Comments)
Tags:
Comment:
freeResult, removed debug functions
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php
@@ -182,13 +182,7 @@
183183 break;
184184 }
185185
186 - ob_start();
187 - var_dump( $queryResult );
188 - var_dump( $recordSet );
189 - var_dump( $editor );
190 - wfDebug( ob_get_contents() );
191 - ob_end_clean();
192 -
 186+ $dbr->freeResult( $queryResult );
193187 $output = $editor->view( new IdStack( $prefix . 'table' ), $recordSet );
194188 // $output="<table><tr><td>HELLO ERIK!</td></tr></table>";
195189 // wfDebug($output);

Comments

#Comment by Reedy (talk | contribs)   20:20, 8 August 2011

Using freeResult is not really needed

In core you'll see most (if not all) calls to it have been removed

#Comment by Kipmaster (talk | contribs)   07:50, 9 August 2011

Thanks for the info!

Status & tagging log