r94038 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94037‎ | r94038 | r94039 >
Date:06:14, 7 August 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Remove implementation of font-scale. Need to find a better way to achieve uniform scaling. Marking as TODO item for now.
Modified paths:
  • /trunk/extensions/WebFonts/js/webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/js/webfonts.js
@@ -71,7 +71,9 @@
7272 * @param percentage of scale. eg 1.2 for 120% scale
7373 */
7474 scale : function (percentage){
75 - $("p,li,h1,h2,h3,h4,h5,textarea,input").css('font-size', percentage + "em");
 75+ //TODO: Not Implemented. Need to find a better way to emulate fontconfig font-scale feature.
 76+ //Changing the font-size of few selectors does not work properly and not able to achieve
 77+ //uniform scaling.
7678 },
7779
7880 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91815if we scale the $(body), interface is becoming wrong. Apply the font scaling,...santhosh06:42, 10 July 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   08:04, 16 August 2011

This commit address r91815 code review.

Status & tagging log