r93911 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93910‎ | r93911 | r93912 >
Date:20:55, 4 August 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it
Modified paths:
  • /trunk/extensions/Configure/Configure.obj.php (modified) (history)
  • /trunk/phase3/includes/SiteConfiguration.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SiteConfiguration.php
@@ -205,10 +205,6 @@
206206 return $this->wikis;
207207 }
208208
209 - /** A no-op */
210 - function initialise() {
211 - }
212 -
213209 /**
214210 * Retrieves the value of a given setting, and places it in a variable passed by reference.
215211 * @param $setting String ID of the setting name to retrieve
Index: trunk/extensions/Configure/Configure.obj.php
@@ -28,8 +28,6 @@
2929 * directory
3030 */
3131 public function initialise( $useCache = true ) {
32 - parent::initialise();
33 -
3432 // Special case for manage.php maintenance script so that it can work
3533 // even if the current configuration is broken
3634 if ( defined( 'EXT_CONFIGURE_NO_EXTRACT' ) )

Comments

#Comment by Reedy (talk | contribs)   13:26, 5 August 2011

I've got some of this hacked into my dev install for SiteMatrix and stuff, and removing initialise() even though it's a noop broke shizz

#Comment by Reedy (talk | contribs)   13:27, 5 August 2011

Though, if it's also a noop in 1.17 etc, we can just remove it out now (from wgConf.php)

#Comment by 😂 (talk | contribs)   14:43, 5 August 2011

If I broke stuff, feel free to revert. You won't hurt my feelings :)

#Comment by Reedy (talk | contribs)   15:11, 5 August 2011

It's a noop in 1.17wmf1 too.

Could just remove the initialise from the WMF config files, and push this into 1.18 too

#Comment by Reedy (talk | contribs)   15:57, 8 August 2011

I removed this from the wmf-config so shouldn't be an issue

Status & tagging log