r9391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9390‎ | r9391 | r9392 >
Date:09:26, 11 June 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2384) Fix typo in regex for IP address checking
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -137,7 +137,7 @@
138138 * @return bool
139139 */
140140 function isIP( $name ) {
141 - return preg_match("/^\d{1,3}\.\d{1,3}.\d{1,3}\.\d{1,3}$/",$name);
 141+ return preg_match("/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/",$name);
142142 /*return preg_match("/^
143143 (?:[01]?\d{1,2}|2(:?[0-4]\d|5[0-5]))\.
144144 (?:[01]?\d{1,2}|2(:?[0-4]\d|5[0-5]))\.
Index: trunk/phase3/RELEASE-NOTES
@@ -276,6 +276,7 @@
277277 * (bug 2368) Avoid fatally breaking PHP 4.1.2 in a debug line
278278 * (bug 2367) Insert correct redirect link record on page move
279279 * (bug 2372) Fix rendering of empty-title inline interwiki links
 280+* (bug 2384) Fix typo in regex for IP address checking
280281
281282
282283 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r9392* (bug 2384) Fix typo in regex for IP address checkingvibber09:32, 11 June 2005
r9394* (bug 2384) Fix typo in regex for IP address checking...vibber11:44, 11 June 2005

Status & tagging log