r9392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9391‎ | r9392 | r9393 >
Date:09:32, 11 June 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2384) Fix typo in regex for IP address checking
Modified paths:
  • /branches/REL1_4/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_4/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: branches/REL1_4/phase3/includes/User.php
@@ -112,7 +112,7 @@
113113 * @static
114114 */
115115 function isIP( $name ) {
116 - return preg_match("/^\d{1,3}\.\d{1,3}.\d{1,3}\.\d{1,3}$/",$name);
 116+ return preg_match("/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/",$name);
117117 }
118118
119119 /**
Index: branches/REL1_4/phase3/RELEASE-NOTES
@@ -638,17 +638,18 @@
639639 * Regression fix: watchlist day cutoff
640640 * (bug 2173) Fatal error when removing an article with an empty title from the watchlist
641641 * (bug 2034) Armor HTML attributes against template inclusion and links munging
642 -* (bug 1976) fix shared user database with a table prefix set
643 -* (bug 2309) Allow templates and template parameters in HTML attribute zone,
644 - with proper validation checks. (regression from fix for 2304)
645642
646643
647644 === 1.4.6 changes ===
648645
649646 * New covering index was added on cur for query speedups.
650647 * (bug 2228) Updated the Slovak translation
 648+* (bug 1976) fix shared user database with a table prefix set
 649+* (bug 2309) Allow templates and template parameters in HTML attribute zone,
 650+ with proper validation checks. (regression from fix for 2304)
651651 * (bug 2355) Use content language in image blacklist check
652652 * (bug 2368) Avoid fatally breaking PHP 4.1.2 in a debug line
 653+* (bug 2384) Fix typo in regex for IP address checking
653654
654655
655656 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r9394* (bug 2384) Fix typo in regex for IP address checking...vibber11:44, 11 June 2005

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r9391* (bug 2384) Fix typo in regex for IP address checkingvibber09:26, 11 June 2005

Status & tagging log