r93901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93900‎ | r93901 | r93902 >
Date:17:12, 4 August 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
dba_open(/usr/local/apache/common/wikiversions.cdb): failed to open stream: No such file or directory in /home/wikipedia/common/multiversion/MWMultiVersion.php on line 218 Warning: dba_close() expects parameter 1 to be resource, boolean given in /home/wikipedia/common/multiversion/MWMultiVersion.php on line 23

Only call dba_close if !$db, as dba_close( false ) doesn't work too well
Modified paths:
  • /trunk/tools/mwmultiversion/multiversion/MWMultiVersion.php (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/MWMultiVersion.php
——@@ -233,8 +233,8 @@
234234 //trigger_error( "Unable to open wikiversions.cdb. Assuming php-1.17", E_USER_ERROR );
235235 $version = 'php-1.17';
236236 $extraVersion = '';
 237+ dba_close( $db );
237238 }
238 - dba_close( $db );
239239
240240 $this->version = $version;
241241 $this->extVersion = $extraVersion;

Follow-up revisions

RevisionCommit summaryAuthorDate
r93902Fix the fail from r93901reedy17:18, 4 August 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   17:18, 4 August 2011

This is backwards :)

Status & tagging log