r93871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93870‎ | r93871 | r93872 >
Date:00:57, 4 August 2011
Author:mah
Status:ok (Comments)
Tags:config, scaptrap 
Comment:
Fix bug #27132: Uncomment movefile right in default settings
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -3351,7 +3351,7 @@
33523352 $wgGroupPermissions['user']['move'] = true;
33533353 $wgGroupPermissions['user']['move-subpages'] = true;
33543354 $wgGroupPermissions['user']['move-rootuserpages'] = true; // can move root userpages
3355 -//$wgGroupPermissions['user']['movefile'] = true; // Disabled for now due to possible bugs and security concerns
 3355+$wgGroupPermissions['user']['movefile'] = true;
33563356 $wgGroupPermissions['user']['read'] = true;
33573357 $wgGroupPermissions['user']['edit'] = true;
33583358 $wgGroupPermissions['user']['createpage'] = true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r93889re r93871 — add release notesmah14:25, 4 August 2011

Comments

#Comment by Bryan (talk | contribs)   07:11, 4 August 2011

RELEASE-NOTES

#Comment by Umherirrender (talk | contribs)   21:20, 14 August 2011

scaptrap?

I am not sure, if this change will not bypass the setting of wikis of the Wikimedia Foundation. I would be happy, if someone can check this, because not all communitys are amused, if all users can move files. Thanks.

#Comment by Catrope (talk | contribs)   21:28, 14 August 2011

Yes, you're right, the WMF config doesn't account for this. Prior to deploying this, we'd have to make sure 'movefile' is restricted either in a way that makes sense given the wiki's existing movefile restrictions (some wikis limit movefile to filemovers, and set it to false even for sysops) or restrict it in the same way that 'move' is restricted on that wiki. Does that sound reasonable?

#Comment by MZMcBride (talk | contribs)   05:40, 5 July 2012

No, it really doesn't sound reasonable. Is there any good reason to restrict (or encourage restricting) file moving? Why is a separate user group needed here when there's no separate user group for moving a wiki page? This doesn't make any sense to me.

Status & tagging log