r93847 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93846‎ | r93847 | r93848 >
Date:18:25, 3 August 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow-up r93258, r93266, r93266: Move the defines to Defines.php
Modified paths:
  • /trunk/phase3/includes/Defines.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Defines.php
@@ -240,3 +240,12 @@
241241 define( 'APCOND_BLOCKED', 8 );
242242 define( 'APCOND_ISBOT', 9 );
243243 /**@}*/
 244+
 245+/**
 246+ * Protocol constants for wfExpandUrl()
 247+ */
 248+define( 'PROTO_HTTP', 'http://' );
 249+define( 'PROTO_HTTPS', 'https://' );
 250+define( 'PROTO_RELATIVE', '//' );
 251+define( 'PROTO_CURRENT', null );
 252+
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -428,11 +428,6 @@
429429 return $url;
430430 }
431431
432 -define( 'PROTO_HTTP', 'http://' );
433 -define( 'PROTO_HTTPS', 'https://' );
434 -define( 'PROTO_RELATIVE', '//' );
435 -define( 'PROTO_CURRENT', null );
436 -
437432 /**
438433 * Expand a potentially local URL to a fully-qualified URL. Assumes $wgServer
439434 * is correct.

Follow-up revisions

RevisionCommit summaryAuthorDate
r955051.17wmf1: Merge a truckload of HTTPS / prot rel URL fixes: r93847, r94990, r9...catrope19:32, 25 August 2011
r95607MFT to REL1_18...hashar19:28, 27 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93258(bug NNNNN) Rewrite most of wfExpandUrl() to handle protocol-relative URLs pr...catrope08:21, 27 July 2011
r93266Rename PROT_* constants to PROTO_*...platonides14:06, 27 July 2011

Status & tagging log