r93817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93816‎ | r93817 | r93818 >
Date:11:59, 3 August 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Fix noglobals exceptions from QUnit
* Test results prior to this commit: http://i.imgur.com/m8rbk.png
* http://localhost/trunkw/tests/qunit/?noglobals=1

- Missing var-statement, causes global scope implication
- Missing semi colon, causing next to be global
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.textSelection.js (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.Title.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.textSelection.js
@@ -454,7 +454,7 @@
455455 context.fn.restoreSelection();
456456 needSave = true;
457457 }
458 - retval = ( hasIframe ? context.fn : fn )[command].call( this, options );
 458+ var retval = ( hasIframe ? context.fn : fn )[command].call( this, options );
459459 if ( hasIframe && needSave ) {
460460 context.fn.saveSelection();
461461 }
Index: trunk/phase3/resources/mediawiki/mediawiki.Title.js
@@ -120,7 +120,7 @@
121121 * @return {mw.Title}
122122 */
123123 setAll = function( title, s ) {
124 - var matches = s.match( /^(?:([^:]+):)?(.*?)(?:\.(\w{1,5}))?$/ );
 124+ var matches = s.match( /^(?:([^:]+):)?(.*?)(?:\.(\w{1,5}))?$/ ),
125125 ns_match = getNsIdByName( matches[1] );
126126 if ( matches.length && ns_match ) {
127127 if ( matches[1] ) { title._ns = ns_match; }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71991Reorganized modules into more shallow structures. Using existing files for le...tparscal23:03, 30 August 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   12:34, 3 August 2011

Confirmed fix, shouldn't affect functionality negatively in any way.

Status & tagging log