r93807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93806‎ | r93807 | r93808 >
Date:07:59, 3 August 2011
Author:midom
Status:ok
Tags:
Comment:
we don't need to change charsets on our systems, as we already have BINARY all around
we dont't set SQL modes either..
Modified paths:
  • /branches/wmf/1.17wmf1/includes/db/DatabaseMysql.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/db/DatabaseMysql.php
@@ -108,6 +108,7 @@
109109 }
110110
111111 if ( $success ) {
 112+ /*
112113 $version = $this->getServerVersion();
113114 if ( version_compare( $version, '4.1' ) >= 0 ) {
114115 // Tell the server we're communicating with it in UTF-8.
@@ -125,6 +126,7 @@
126127 $this->query( "SET sql_mode = $mode", __METHOD__ );
127128 }
128129 }
 130+ */
129131
130132 // Turn off strict mode if it is on
131133 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r975051.18wmf1 Merge r83867, r93686, r93807, r93971, r93972 (some manually do to lo...reedy15:31, 19 September 2011

Status & tagging log