r93706 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93705‎ | r93706 | r93707 >
Date:07:59, 2 August 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
adding pokey graphic to Moodbar pop-up
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/images/pokey.png (added) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css
@@ -1,12 +1,14 @@
22 /* Overlay styling */
33 #mw-moodBar-overlayWrap {
44 position: absolute;
5 - top: 4em;
 5+ top: 3.5em;
66 left: 10.2em;
77 min-width: 100px;
88 min-height: 100px;
99 background: #fafafa;
1010 border: 1px solid #0645ad;
 11+ -moz-border-radius: 40px;
 12+ -webkit-border-radius: 40px;
1113 border-radius: 40px;
1214 box-shadow: 7px 7px 15px rgba(0, 0, 0, 0.5);
1315 display: none;
@@ -14,8 +16,18 @@
1517
1618 #mw-moodBar-overlay {
1719 margin: 22px 22px;
 20+ position: relative;
1821 }
1922
 23+#mw-moodBar-pokey {
 24+ position: absolute;
 25+ top: -59px;
 26+ left: 14px;
 27+ background: transparent url(images/pokey.png) center top no-repeat;
 28+ width: 49px;
 29+ height: 37px;
 30+}
 31+
2032 .mw-moodBar-overlayTitle {
2133 font-weight: bold;
2234 white-space: nowrap;
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -11,6 +11,7 @@
1212 tpl: {
1313 overlayBase: '\
1414 <div id="mw-moodBar-overlayWrap"><div id="mw-moodBar-overlay">\
 15+ <div id="mw-moodBar-pokey"></div>\
1516 <span class="mw-moodBar-overlayClose"><a href="#"><html:msg key="moodbar-close" /></a></span>\
1617 <div class="mw-moodBar-overlayContent"></div>\
1718 </div></div>',
Index: trunk/extensions/MoodBar/modules/ext.moodBar/images/pokey.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/MoodBar/modules/ext.moodBar/images/pokey.png
___________________________________________________________________
Added: svn:mime-type
1819 + application/octet-stream

Sign-offs

UserFlagDate
Jorm (WMF)tested17:54, 24 August 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r94167fixing mime types of png image per comment at r93706kaldari16:45, 10 August 2011
r95405Followup r93706: add @embedcatrope17:56, 24 August 2011

Comments

#Comment by 😂 (talk | contribs)   12:33, 10 August 2011

mime-type on the png file is incorrect.

#Comment by Kaldari (talk | contribs)   16:45, 10 August 2011

fixed in r94167.

Status & tagging log