r93687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93686‎ | r93687 | r93688 >
Date:23:35, 1 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Commit live hack

Commit to trunk also
Modified paths:
  • /branches/wmf/1.17wmf1/includes/specials/SpecialUploadStash.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUploadStash.php
@@ -226,8 +226,10 @@
227227 $req = MWHttpRequest::factory( $scalerThumbUrl, $httpOptions );
228228 $status = $req->execute();
229229 if ( ! $status->isOK() ) {
230 - $errors = $status->getWikiTextArray( $status->getErrorsArray() );
231 - throw new MWException( "Fetching thumbnail failed: " . print_r( $errors, 1 ) );
 230+ $errors = $status->getErrorsArray();
 231+ $errorStr = "Fetching thumbnail failed: " . print_r( $errors, 1 );
 232+ $errorStr .= "\nurl = $scalerThumbUrl\n";
 233+ throw new MWException( $errorStr );
232234 }
233235 $contentType = $req->getResponseHeader( "content-type" );
234236 if ( ! $contentType ) {
Index: branches/wmf/1.17wmf1/includes/specials/SpecialUploadStash.php
@@ -226,8 +226,10 @@
227227 $req = MWHttpRequest::factory( $scalerThumbUrl, $httpOptions );
228228 $status = $req->execute();
229229 if ( ! $status->isOK() ) {
230 - $errors = $status->getErrorsArray();
231 - throw new MWException( "Fetching thumbnail failed: " . print_r( $errors, 1 ) );
 230+ $errors = $status->getErrorsArray();
 231+ $errorStr = "Fetching thumbnail failed: " . print_r( $errors, 1 );
 232+ $errorStr .= "\nurl = $scalerThumbUrl\n";
 233+ throw new MWException( $errorStr );
232234 }
233235 $contentType = $req->getResponseHeader( "content-type" );
234236 if ( ! $contentType ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r96554MFT r93687reedy11:21, 8 September 2011

Status & tagging log