r93677 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93676‎ | r93677 | r93678 >
Date:23:20, 1 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Commit AF live hack that hasn't made it back to trunk either
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -217,6 +217,9 @@
218218 foreach ( $problems as $page ) {
219219 $row = array();
220220 $pageTitle = self::getTitleFromID( $page['page'] );
 221+ if ( !$pageTitle ) {
 222+ continue;
 223+ }
221224 $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
222225 foreach ( $page['ratings'] as $id => $value ) {
223226 $row[] = array(
@@ -373,7 +376,7 @@
374377 $num_highs = $num_ratings / 2;
375378 }
376379 $highs = array_slice( $highs_lows, -$num_highs, $num_highs );
377 -
 380+
378381 // Sort descending
379382 return array_reverse( $highs );
380383 }
Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -217,6 +217,9 @@
218218 foreach ( $problems as $page ) {
219219 $row = array();
220220 $pageTitle = self::getTitleFromID( $page['page'] );
 221+ if ( $pageTitle ) {
 222+ continue;
 223+ }
221224 $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
222225 foreach ( $page['ratings'] as $id => $value ) {
223226 $row[] = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r94134Followup r93677: add missing !catrope19:05, 9 August 2011
r107332Originally fixed in trunk back in r93677, so no idea why it is still there....reedy18:10, 26 December 2011

Status & tagging log