r93594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93593‎ | r93594 | r93595 >
Date:16:38, 31 July 2011
Author:yaron
Status:ok (Comments)
Tags:
Comment:
Fix to r85127 - better check for SMW 1.6
Modified paths:
  • /trunk/extensions/SemanticInternalObjects/SemanticInternalObjects_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticInternalObjects/SemanticInternalObjects_body.php
——@@ -150,8 +150,8 @@
151151 'value_num' => $valueNum
152152 );
153153
154 - // getUnit() was removed in SMW 1.6
155 - if ( method_exists( $value, 'getUnit' ) ) {
 154+ // 'value_unit' DB field was removed in SMW 1.6
 155+ if ( version_compare( SMW_VERSION, '1.6 alpha', '<' ) ) {
156156 $upAttr['value_unit'] = $value->getUnit();
157157 }
158158

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85127fixing compat with SMW 1.6jeroendedauw15:39, 1 April 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   17:24, 31 July 2011

Ah, now I fully get what you where talking about; seems like I didn't know this method was still present for some types when making this commit.

Status & tagging log